[GitHub] [flink] nielsbasjes edited a comment on pull request #12846: [FLINK-18448][pubsub] Update Google Cloud PubSub dependencies

[GitBox <gi...@apache.org>]

nielsbasjes edited a comment on pull request #12846:
URL: https://github.com/apache/flink/pull/12846#issuecomment-658267581


   Notes about the current set of changes:
   - Updated the Google dependencies. All Google dependencies no longer specify any versions. So in all cases the inclusion of the `libraries-bom` is needed. At this point I chose to make it such that downstream projects must specify which `libraries-bom` version they need. Although this is an extra step for users I hope this will make updating to newer versions of the Google tools easier.
   - I fixed almost all cases of Google/Flink api's that have become deprecated over time. One clear exception: The use of the ListCheckpointed. This seemed to become too large ( a full rewrite of the handling of the acknowledgements ) so I think it should be a separate effort.
   - I replaced the use of the NoCredentials and NoCredentialsProvider with custom implementations because I ran into problems. See also my bug report towards Google https://github.com/googleapis/gax-java/issues/1148
   - I added a full end-to-end test that both reads from and writes to PubSub.
   - I updated the tests to run in parallel 4 (instead of 1) which surfaced a small bug that only appears on "ending" streams (like we only have in test scenarios). Solution: Move the closing of the connection to a slightly later point. This also meant that the `BoundedStringDeserializer` which counted the number of messages could no longer be used.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org