[GitHub] [ignite] tledkov-gridgain commented on a change in pull request #9787: IGNITE-16191 Calcite engine. Unexpected result of COUNT with multiple parameters

[GitBox <gi...@apache.org>]

tledkov-gridgain commented on a change in pull request #9787:
URL: https://github.com/apache/ignite/pull/9787#discussion_r799550392



##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/agg/AccumulatorsFactory.java
##########
@@ -214,6 +214,11 @@ private WrapperPrototype(AggregateCall call) {
             List<RelDataType> inTypes = SqlTypeUtil.projectTypes(inputRowType, call.getArgList());
             List<RelDataType> outTypes = accumulator.argumentTypes(ctx.getTypeFactory());
 
+            if (call.getArgList().size() > outTypes.size()) {

Review comment:
       Is the check is necessary? Does the validator pass count with multiple arguments?
   Is the check valid for other accumulators? e.g. LIST_AGG, etc?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org