You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/03 17:05:00 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #10507: docs: new contributing language around adding new plugins
rusackas opened a new pull request #10507:
URL: https://github.com/apache/incubator-superset/pull/10507
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
I'd promised to add some language like this previously, so here it is! Next steps include getting Superset-UI to build community-contributed plugins from a `community-plugins` directory, and then we'll update this again with info/steps to follow through on that plan.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #10507: docs: new contributing language around adding new plugins
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #10507:
URL: https://github.com/apache/incubator-superset/pull/10507#discussion_r464618509
##########
File path: CONTRIBUTING.md
##########
@@ -847,6 +847,18 @@ The topic of authoring new plugins, whether you'd like to contribute
it back or not has been well documented in the
[So, You Want to Build a Superset Viz Plugin...](https://preset.io/blog/2020-07-02-hello-world/) blog post
+To contribute a plugin to Superset-UI, your plugin must meet the following criteria:
+* The plugin should be applicable to the community at large, not a particularly specialized use case
+* The plugin should be written with typescript
Review comment:
```suggestion
* The plugin should be written with TypeScript
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10507: docs: new contributing language around adding new plugins
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10507:
URL: https://github.com/apache/incubator-superset/pull/10507#discussion_r464670620
##########
File path: CONTRIBUTING.md
##########
@@ -814,7 +814,7 @@ Then, [extract strings for the new language](#extracting-new-strings-for-transla
### Improving visualizations
-Superset is working towards a plugin system where new visualizations can be installed as optional npm packages. To achieve this goal, we are not accepting pull requests for new community-contributed visualization types at the moment. However, bugfixes for current visualizations are welcome. To edit the frontend code for visualizations, you will have to check out a copy of [apache-superset/superset-ui](https://github.com/apache-superset/superset-ui):
+Bugfixes for core visualizations are welcome. To edit the frontend code for visualizations, you will have to check out a copy of [apache-superset/superset-ui](https://github.com/apache-superset/superset-ui):
Review comment:
```suggestion
To edit the frontend code for visualizations, you will have to check out a copy of [apache-superset/superset-ui](https://github.com/apache-superset/superset-ui):
```
The language about bugfixes doesn't seem necessary, either. Plus the improvements can be more than bugfixes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #10507: docs: new contributing language around adding new plugins
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10507:
URL: https://github.com/apache/incubator-superset/pull/10507
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org