You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ha...@apache.org on 2023/11/30 04:52:20 UTC
svn commit: r1914221 - /subversion/branches/1.14.x/STATUS
Author: hartmannathan
Date: Thu Nov 30 04:52:20 2023
New Revision: 1914221
URL: http://svn.apache.org/viewvc?rev=1914221&view=rev
Log:
* STATUS: Nominate r1914220.
Modified:
subversion/branches/1.14.x/STATUS
Modified: subversion/branches/1.14.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1914221&r1=1914220&r2=1914221&view=diff
==============================================================================
--- subversion/branches/1.14.x/STATUS (original)
+++ subversion/branches/1.14.x/STATUS Thu Nov 30 04:52:20 2023
@@ -22,6 +22,13 @@ Candidate changes:
votes:
+1: rhuijben
+ * r1914220
+ Update copyright year to 2023.
+ Justification:
+ To show correct year in upcoming release.
+ Votes:
+ +1: hartmannathan
+
Veto-blocked changes:
=====================
Re: svn commit: r1914221 - /subversion/branches/1.14.x/STATUS
Posted by Daniel Sahlberg <da...@gmail.com>.
Den tors 30 nov. 2023 kl 05:57 skrev Nathan Hartman <
hartman.nathan@gmail.com>:
> On Wed, Nov 29, 2023 at 11:52 PM <ha...@apache.org> wrote:
> >
> > Author: hartmannathan
> > Date: Thu Nov 30 04:52:20 2023
> > New Revision: 1914221
> >
> > URL: http://svn.apache.org/viewvc?rev=1914221&view=rev
> > Log:
> > * STATUS: Nominate r1914220.
> >
> > Modified:
> > subversion/branches/1.14.x/STATUS
> >
> > Modified: subversion/branches/1.14.x/STATUS
> > URL:
> http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1914221&r1=1914220&r2=1914221&view=diff
> >
> ==============================================================================
> > --- subversion/branches/1.14.x/STATUS (original)
> > +++ subversion/branches/1.14.x/STATUS Thu Nov 30 04:52:20 2023
> > @@ -22,6 +22,13 @@ Candidate changes:
> > votes:
> > +1: rhuijben
> >
> > + * r1914220
> > + Update copyright year to 2023.
> > + Justification:
> > + To show correct year in upcoming release.
> > + Votes:
> > + +1: hartmannathan
>
>
> I don't know whether this really needs a nomination and vote -- I
> looked for precedents and found that sometimes the year bump was
> committed directly on a A.B.x branch, sometimes committed to trunk and
> merged without a nomination/vote to a A.B.x branch, and sometimes done
> via a vote... So I went ahead and took the most conservative approach,
> but if it's overkill, please let me know for the future.
>
> Thanks,
> Nathan
>
It doesn't hurt I guess. I'm +1 for changing the year ;-) so I went ahead
and approved. Not sure if it would have needed three +1 but I don't think
anyone can veto...
/Daniel
Re: svn commit: r1914221 - /subversion/branches/1.14.x/STATUS
Posted by Nathan Hartman <ha...@gmail.com>.
On Wed, Nov 29, 2023 at 11:52 PM <ha...@apache.org> wrote:
>
> Author: hartmannathan
> Date: Thu Nov 30 04:52:20 2023
> New Revision: 1914221
>
> URL: http://svn.apache.org/viewvc?rev=1914221&view=rev
> Log:
> * STATUS: Nominate r1914220.
>
> Modified:
> subversion/branches/1.14.x/STATUS
>
> Modified: subversion/branches/1.14.x/STATUS
> URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1914221&r1=1914220&r2=1914221&view=diff
> ==============================================================================
> --- subversion/branches/1.14.x/STATUS (original)
> +++ subversion/branches/1.14.x/STATUS Thu Nov 30 04:52:20 2023
> @@ -22,6 +22,13 @@ Candidate changes:
> votes:
> +1: rhuijben
>
> + * r1914220
> + Update copyright year to 2023.
> + Justification:
> + To show correct year in upcoming release.
> + Votes:
> + +1: hartmannathan
I don't know whether this really needs a nomination and vote -- I
looked for precedents and found that sometimes the year bump was
committed directly on a A.B.x branch, sometimes committed to trunk and
merged without a nomination/vote to a A.B.x branch, and sometimes done
via a vote... So I went ahead and took the most conservative approach,
but if it's overkill, please let me know for the future.
Thanks,
Nathan