You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "xushiyan (via GitHub)" <gi...@apache.org> on 2023/03/06 21:05:00 UTC

[GitHub] [hudi] xushiyan commented on a diff in pull request #8086: [HUDI-5872] Abstraction for DeltaSyncService and DeltaStreamerMetrics

xushiyan commented on code in PR #8086:
URL: https://github.com/apache/hudi/pull/8086#discussion_r1127031441


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java:
##########
@@ -883,9 +877,19 @@ public SparkSession getSparkSession() {
     public TypedProperties getProps() {
       return props;
     }
+
+    /**
+     * This API is for testing only.
+     */
+    public DeltaSync getDeltaSync() {
+      return deltaSync;
+    }
   }
 
-  public DeltaSyncService getDeltaSyncService() {
-    return deltaSyncService.get();
+  /**
+   * This API is for testing only.
+   */

Review Comment:
   this is already there. annotated instead of javadoc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org