You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by se...@apache.org on 2012/01/04 03:06:44 UTC
svn commit: r1227025 - in /jmeter/trunk:
src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java
src/reports/org/apache/jmeter/testelement/JTLData.java
test/src/org/apache/jmeter/functions/PackageTest.java
Author: sebb
Date: Wed Jan 4 02:06:43 2012
New Revision: 1227025
URL: http://svn.apache.org/viewvc?rev=1227025&view=rev
Log:
Useless null stores (Findbugs)
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java
jmeter/trunk/src/reports/org/apache/jmeter/testelement/JTLData.java
jmeter/trunk/test/src/org/apache/jmeter/functions/PackageTest.java
Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java?rev=1227025&r1=1227024&r2=1227025&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java Wed Jan 4 02:06:43 2012
@@ -254,7 +254,6 @@ public class TCLogParser implements LogP
}
if (line == null) {
breader.close();
- breader = null;
this.READER = null;
// this.READER = new BufferedReader(new
// FileReader(this.SOURCE));
Modified: jmeter/trunk/src/reports/org/apache/jmeter/testelement/JTLData.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/reports/org/apache/jmeter/testelement/JTLData.java?rev=1227025&r1=1227024&r2=1227025&view=diff
==============================================================================
--- jmeter/trunk/src/reports/org/apache/jmeter/testelement/JTLData.java (original)
+++ jmeter/trunk/src/reports/org/apache/jmeter/testelement/JTLData.java Wed Jan 4 02:06:43 2012
@@ -179,7 +179,6 @@ public class JTLData implements Serializ
// no slow leaks
rc.clear();
rc.setListener(null);
- rc = null;
}
}
Modified: jmeter/trunk/test/src/org/apache/jmeter/functions/PackageTest.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/functions/PackageTest.java?rev=1227025&r1=1227024&r2=1227025&view=diff
==============================================================================
--- jmeter/trunk/test/src/org/apache/jmeter/functions/PackageTest.java (original)
+++ jmeter/trunk/test/src/org/apache/jmeter/functions/PackageTest.java Wed Jan 4 02:06:43 2012
@@ -917,19 +917,20 @@ public class PackageTest extends JMeterT
}
public void sumTest() throws Exception {
+ String maxIntVal = Integer.toString(Integer.MAX_VALUE);
+ String minIntVal = Integer.toString(Integer.MIN_VALUE);
+
+ { // prevent accidental use of is below
IntSum is = new IntSum();
checkInvalidParameterCounts(is,2);
checkSum(is,"3", new String[]{"1","2"});
checkSumNoVar(is,"3", new String[]{"1","2"});
checkSum(is,"1", new String[]{"-1","1","1","1","-2","1"});
checkSumNoVar(is,"1", new String[]{"-1","1","1","1","-2","1"});
- String maxIntVal = Integer.toString(Integer.MAX_VALUE);
- String minIntVal = Integer.toString(Integer.MIN_VALUE);
checkSum(is,maxIntVal, new String[]{maxIntVal,"0"});
checkSum(is,minIntVal, new String[]{maxIntVal,"1"}); // wrap-round check
+ }
- is = null; // prevent accidental use below
-
LongSum ls = new LongSum();
checkInvalidParameterCounts(ls,2);
checkSum(ls,"3", new String[]{"1","2"});