You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2020/04/14 23:01:52 UTC
[impala] branch master updated (76e4a17 -> 9ea8b14)
This is an automated email from the ASF dual-hosted git repository.
stigahuang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git.
from 76e4a17 IMPALA-9643: fix runtime filter race for mt_dop
new 82ca326 IMPALA-9071: remove xfail from ACID CTAS test
new 8d26432 IMPALA-9650: Fix flakiness in RuntimeFilterTest
new 9ea8b14 IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
be/src/runtime/runtime-filter.cc | 2 --
.../authorization/ranger/RangerImpaladAuthorizationManager.java | 4 +---
.../java/org/apache/impala/authorization/AuthorizationTestBase.java | 3 ++-
tests/custom_cluster/test_custom_hive_configs.py | 2 --
4 files changed, 3 insertions(+), 8 deletions(-)
[impala] 02/03: IMPALA-9650: Fix flakiness in RuntimeFilterTest
Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 8d264321efe370924b3e60fafad9aca1347a4dc1
Author: Riza Suminto <ri...@cloudera.com>
AuthorDate: Mon Apr 13 15:19:59 2020 -0700
IMPALA-9650: Fix flakiness in RuntimeFilterTest
IMPALA-9612 adds RuntimeFilterTest to the set of backend tests. It
adds a delay injection code in runtime-filter.cc to reproduce the race
condition. However, the delay injection code will be stripped out when
Impala is build with release config. This patch remove the NDEBUG
macro enclosing the delay injection code so that it will not be
stripped out in release build.
Testing:
- Ran and pass pass backend tests against release build.
Change-Id: Ie3a5e68a128a97524755eeee4f8a993f38a0ed48
Reviewed-on: http://gerrit.cloudera.org:8080/15726
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
be/src/runtime/runtime-filter.cc | 2 --
1 file changed, 2 deletions(-)
diff --git a/be/src/runtime/runtime-filter.cc b/be/src/runtime/runtime-filter.cc
index 1ff0a13..04be0ab 100644
--- a/be/src/runtime/runtime-filter.cc
+++ b/be/src/runtime/runtime-filter.cc
@@ -81,9 +81,7 @@ bool RuntimeFilter::WaitForArrival(int32_t timeout_ms) const {
int64_t ms_since_registration = MonotonicMillis() - registration_time_;
int64_t ms_remaining = timeout_ms - ms_since_registration;
if (ms_remaining <= 0) break;
-#ifndef NDEBUG
if (injection_delay_ > 0) SleepForMs(injection_delay_);
-#endif
arrival_cv_.WaitFor(l, ms_remaining * MICROS_PER_MILLI);
}
return arrival_time_.Load() != 0;
[impala] 03/03: IMPALA-9651: Update Ranger's Impala plugin to
replace use of deprecated APIs
Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 9ea8b1454fabf5872459cd8ae6af60e8d89f62a5
Author: Fang-Yu Rao <fa...@cloudera.com>
AuthorDate: Mon Apr 13 13:45:01 2020 -0700
IMPALA-9651: Update Ranger's Impala plugin to replace use of deprecated APIs
RangerAuthContext#getResourceACLs() was deprecated due to a recent
change in RANGER-2654 and the constructor
RangerRESTClient(String, String) of the class RangerRESTClient was
also recently deprecated in RANGER-2646. This patch replaces the
references to these two methods with the updated APIs respectively.
Testing:
- Verified that this patch passes the exhaustive tests in the DEBUG
build.
Change-Id: Ia6dfd1107928c2c4b971e7cec48463ba34b25b3b
Reviewed-on: http://gerrit.cloudera.org:8080/15731
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
.../authorization/ranger/RangerImpaladAuthorizationManager.java | 4 +---
.../java/org/apache/impala/authorization/AuthorizationTestBase.java | 3 ++-
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java b/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
index 369b232..fc1faad 100644
--- a/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
+++ b/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
@@ -76,11 +76,9 @@ public class RangerImpaladAuthorizationManager implements AuthorizationManager {
private static final String ANY = "*";
private final Supplier<RangerImpalaPlugin> plugin_;
- private final Supplier<RangerAuthContext> authContext_;
public RangerImpaladAuthorizationManager(Supplier<RangerImpalaPlugin> pluginSupplier) {
plugin_ = pluginSupplier;
- authContext_ = () -> plugin_.get().createRangerAuthContext();
}
@Override
@@ -302,7 +300,7 @@ public class RangerImpaladAuthorizationManager implements AuthorizationManager {
for (RangerAccessRequest request : requests) {
List<RangerResultRow> resultRows;
- RangerResourceACLs acls = authContext_.get().getResourceACLs(request);
+ RangerResourceACLs acls = plugin_.get().getResourceACLs(request);
switch (params.principal_type) {
case USER:
diff --git a/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java b/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java
index fe15601..cbee2f9 100644
--- a/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java
+++ b/fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java
@@ -149,7 +149,8 @@ public abstract class AuthorizationTestBase extends FrontendTestBase {
.getRangerImpalaPlugin();
assertEquals("test-cluster", rangerImpalaPlugin_.getClusterName());
sentryService_ = null;
- rangerRestClient_ = new RangerRESTClient(RANGER_ADMIN_URL, null);
+ rangerRestClient_ = new RangerRESTClient(RANGER_ADMIN_URL, null,
+ rangerImpalaPlugin_.getConfig());
rangerRestClient_.setBasicAuthInfo(RANGER_USER, RANGER_PASSWORD);
break;
default:
[impala] 01/03: IMPALA-9071: remove xfail from ACID CTAS test
Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 82ca3262b3aeee13d2cc27c5ff9aef3f6c70cc8a
Author: Csaba Ringhofer <cs...@cloudera.com>
AuthorDate: Tue Apr 14 17:21:30 2020 +0200
IMPALA-9071: remove xfail from ACID CTAS test
The test passes at the moment - according to the TODO
it needed HIVE-22158, which is included in CDP dependencies
since a long time.
Change-Id: I4e068879100061bb7e724f0bd1e5e4aa8edd7825
Reviewed-on: http://gerrit.cloudera.org:8080/15729
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
tests/custom_cluster/test_custom_hive_configs.py | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/custom_cluster/test_custom_hive_configs.py b/tests/custom_cluster/test_custom_hive_configs.py
index 513c86a..933a114 100644
--- a/tests/custom_cluster/test_custom_hive_configs.py
+++ b/tests/custom_cluster/test_custom_hive_configs.py
@@ -33,9 +33,7 @@ class TestCustomHiveConfigs(CustomClusterTestSuite):
def setup_class(cls):
super(TestCustomHiveConfigs, cls).setup_class()
- # TODO: Remove the xfail marker after bumping CDP_BUILD_NUMBER to contain HIVE-22158
@SkipIfHive2.acid
- @pytest.mark.xfail(run=True, reason="May fail on Hive3 versions without HIVE-22158")
@pytest.mark.execute_serially
@CustomClusterTestSuite.with_args(hive_conf_dir=HIVE_SITE_EXT_DIR)
def test_ctas_read_write_consistence(self, unique_database):