You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "manuzhang (via GitHub)" <gi...@apache.org> on 2023/06/08 10:46:10 UTC

[GitHub] [iceberg] manuzhang commented on a diff in pull request #7127: [Core][Spark] Improve DeleteOrphanFiles action to return additional details of deleted orphan files

manuzhang commented on code in PR #7127:
URL: https://github.com/apache/iceberg/pull/7127#discussion_r1222859059


##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -144,7 +146,25 @@ default DeleteOrphanFiles equalAuthorities(Map<String, String> newEqualAuthoriti
   @Value.Immutable
   interface Result {
     /** Returns locations of orphan files. */
-    Iterable<String> orphanFileLocations();
+    default Iterable<String> orphanFileLocations() {

Review Comment:
   Can we add a summary like number of removed orphan files?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org