You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2018/01/12 02:33:41 UTC
[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9014
Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length()
......................................................................
IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length()
Modify both char_length() and length() usage notes to say when they
return the same or different results.
Include the same example, showing both STRING and CHAR types,
under both functions.
Change-Id: I18cabfce66351bb890bfbfc26b93466204a82625
---
M docs/shared/impala_common.xml
M docs/topics/impala_string_functions.xml
2 files changed, 61 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/9014/1
--
To view, visit http://gerrit.cloudera.org:8080/9014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I18cabfce66351bb890bfbfc26b93466204a82625
Gerrit-Change-Number: 9014
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9014 )
Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length()
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/189/
--
To view, visit http://gerrit.cloudera.org:8080/9014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18cabfce66351bb890bfbfc26b93466204a82625
Gerrit-Change-Number: 9014
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 22:21:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9014 )
Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length()
......................................................................
Patch Set 1:
Agree with having Greg look it over. If we can +2 it today though, it can make it into the 2.11 docs. Greg won't be back until next week.
How about we +2 this review today and take a longer-term action item to fill in more examples for the string functions, so we can turn up any other examples of STRING / CHAR differences?
--
To view, visit http://gerrit.cloudera.org:8080/9014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18cabfce66351bb890bfbfc26b93466204a82625
Gerrit-Change-Number: 9014
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 20:23:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9014 )
Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length()
......................................................................
Patch Set 1:
Might be worth greg having a quick look if he's interested.
--
To view, visit http://gerrit.cloudera.org:8080/9014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18cabfce66351bb890bfbfc26b93466204a82625
Gerrit-Change-Number: 9014
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 16:14:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()
Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/9014 )
Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length()
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9014/2/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:
http://gerrit.cloudera.org:8080/#/c/9014/2/docs/topics/impala_string_functions.xml@216
PS2, Line 216: STRING
and also VARCHAR, right?
http://gerrit.cloudera.org:8080/#/c/9014/2/docs/topics/impala_string_functions.xml@569
PS2, Line 569: STRING
same - also VARCHAR
--
To view, visit http://gerrit.cloudera.org:8080/9014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18cabfce66351bb890bfbfc26b93466204a82625
Gerrit-Change-Number: 9014
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 13 Jan 2018 00:22:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9014 )
Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length()
......................................................................
IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length()
Modify both char_length() and length() usage notes to say when they
return the same or different results.
Include the same example, showing both STRING and CHAR types,
under both functions.
Change-Id: I18cabfce66351bb890bfbfc26b93466204a82625
Reviewed-on: http://gerrit.cloudera.org:8080/9014
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/shared/impala_common.xml
M docs/topics/impala_string_functions.xml
2 files changed, 61 insertions(+), 5 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I18cabfce66351bb890bfbfc26b93466204a82625
Gerrit-Change-Number: 9014
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9014 )
Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length()
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18cabfce66351bb890bfbfc26b93466204a82625
Gerrit-Change-Number: 9014
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 22:24:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9014 )
Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18cabfce66351bb890bfbfc26b93466204a82625
Gerrit-Change-Number: 9014
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 21:44:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9014 )
Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length()
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9014
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18cabfce66351bb890bfbfc26b93466204a82625
Gerrit-Change-Number: 9014
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 16:14:28 +0000
Gerrit-HasComments: No