You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by janithkv <gi...@git.apache.org> on 2018/11/20 06:10:53 UTC

[GitHub] storm pull request #2911: STORM-2720 : Add TIMESTAMP option for FirstPollOff...

Github user janithkv commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2911#discussion_r234878731
  
    --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java ---
    @@ -137,7 +142,11 @@ public KafkaSpoutConfig(Builder<K, V> builder) {
             /**
              * The kafka spout polls records from the last committed offset, if any. If no offset has been committed it behaves as LATEST
              */
    -        UNCOMMITTED_LATEST;
    +        UNCOMMITTED_LATEST,
    +        /**
    +         * Start at the earliest offset whose timestamp is greater than or equal to the given startTimestamp
    +         */
    +        TIMESTAMP;
    --- End diff --
    
    Hmm not sure. I think practically it might make sense to go back a few minutes rather than all the way upto EARLIEST. But that might be a bit out of scope.


---