You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/04 12:20:55 UTC
[GitHub] [shardingsphere] natehuangting opened a new pull request, #20771: add resource bug
natehuangting opened a new pull request, #20771:
URL: https://github.com/apache/shardingsphere/pull/20771
Fixes #20769 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20771: add resource bug
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20771:
URL: https://github.com/apache/shardingsphere/pull/20771#issuecomment-1236338517
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20771?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20771](https://codecov.io/gh/apache/shardingsphere/pull/20771?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (684f986) into [master](https://codecov.io/gh/apache/shardingsphere/commit/75b2452367267dd39e63c1752576d135cbcd1f20?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75b2452) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #20771 +/- ##
============================================
+ Coverage 61.25% 61.27% +0.01%
Complexity 2419 2419
============================================
Files 3982 3983 +1
Lines 55229 55225 -4
Branches 9373 9372 -1
============================================
+ Hits 33833 33840 +7
+ Misses 18514 18503 -11
Partials 2882 2882
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20771?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/mode/manager/switcher/ResourceSwitchManager.java](https://codecov.io/gh/apache/shardingsphere/pull/20771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWFuYWdlci9zd2l0Y2hlci9SZXNvdXJjZVN3aXRjaE1hbmFnZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ine/type/unicast/ShardingUnicastRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/20771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3R5cGUvdW5pY2FzdC9TaGFyZGluZ1VuaWNhc3RSb3V0aW5nRW5naW5lLmphdmE=) | `95.45% <0.00%> (ø)` | |
| [...ption/DataSourceIntersectionNotFoundException.java](https://codecov.io/gh/apache/shardingsphere/pull/20771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvZXhjZXB0aW9uL0RhdGFTb3VyY2VJbnRlcnNlY3Rpb25Ob3RGb3VuZEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/jdbc/provider/JDBCRepositoryProviderFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/20771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtc3RhbmRhbG9uZS1tb2RlL3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5L3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5LWpkYmMvc2hhcmRpbmdzcGhlcmUtc3RhbmRhbG9uZS1tb2RlLXJlcG9zaXRvcnktamRiYy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL3JlcG9zaXRvcnkvc3RhbmRhbG9uZS9qZGJjL3Byb3ZpZGVyL0pEQkNSZXBvc2l0b3J5UHJvdmlkZXJGYWN0b3J5LmphdmE=) | `100.00% <0.00%> (+33.33%)` | :arrow_up: |
| [...ption/external/sql/ShardingSphereSQLException.java](https://codecov.io/gh/apache/shardingsphere/pull/20771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9leGNlcHRpb24vZXh0ZXJuYWwvc3FsL1NoYXJkaW5nU3BoZXJlU1FMRXhjZXB0aW9uLmphdmE=) | `50.00% <0.00%> (+50.00%)` | :arrow_up: |
| [...ra/util/exception/ShardingSpherePreconditions.java](https://codecov.io/gh/apache/shardingsphere/pull/20771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9leGNlcHRpb24vU2hhcmRpbmdTcGhlcmVQcmVjb25kaXRpb25zLmphdmE=) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
| [...il/exception/external/sql/SQLWrapperException.java](https://codecov.io/gh/apache/shardingsphere/pull/20771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9leGNlcHRpb24vZXh0ZXJuYWwvc3FsL1NRTFdyYXBwZXJFeGNlcHRpb24uamF2YQ==) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on pull request #20771: add resource bug
Posted by GitBox <gi...@apache.org>.
zjcnb commented on PR #20771:
URL: https://github.com/apache/shardingsphere/pull/20771#issuecomment-1236346361
@natehuangting Hi, this pr has some problem, The createNewDataSource method are return an incremental data source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] natehuangting closed pull request #20771: add resource bug
Posted by GitBox <gi...@apache.org>.
natehuangting closed pull request #20771: add resource bug
URL: https://github.com/apache/shardingsphere/pull/20771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] natehuangting commented on pull request #20771: add resource bug
Posted by GitBox <gi...@apache.org>.
natehuangting commented on PR #20771:
URL: https://github.com/apache/shardingsphere/pull/20771#issuecomment-1236457656
> @natehuangting Hi, this pr has some problem, The createNewDataSource method are return an incremental data source.
Thanks! But I think this modification is more intuitive and convenient, and there are less unnecessary calculations. Maybe we can refactor the method name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org