You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/12/06 08:04:12 UTC
Review Request 71884: Updated the `update()` method of isolator to
handle resource limits.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71884/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Greg Mann.
Bugs: MESOS-10065
https://issues.apache.org/jira/browse/MESOS-10065
Repository: mesos
Description
-------
Updated the `update()` method of isolator to handle resource limits.
Diffs
-----
include/mesos/slave/isolator.hpp 65893e176d34d72c7d05a064a3de91217ef769c9
src/slave/containerizer/mesos/isolator.hpp a5586799c47edff9b9db4af70bfd43772bfb7da1
src/slave/containerizer/mesos/isolator.cpp ac333984db5ef0a9fed412c19152edfa4183b0e4
src/slave/containerizer/mesos/isolator_tracker.hpp 563db10a5bfb78b5476100ec430ede69bdb02b31
src/slave/containerizer/mesos/isolator_tracker.cpp c78e883fa49069fbc4ca439e612b62adafa081d9
src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 4bd3d6dad37dee031660c15e957cc36f63e21fcb
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b12b73d8e0161d448075378765e77867521de04e
src/slave/containerizer/mesos/isolators/filesystem/linux.hpp e6fe688a247358f30bed0492ebd1baddac8809e8
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ab192305b53c829fbf6cbf6367ce1686507f9c3d
src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 9db6ddd2d457956f3020a11ba73d96b35b0d8a15
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp dbf149ad9c8fb900bb3b56f6e90b3a8643097d25
src/slave/containerizer/mesos/isolators/gpu/isolator.hpp cc3cab51f7dab4393b101aff8b481a5cd0a01af9
src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 5d1821087491cedd0cfbec5d57340bd927aae725
src/slave/containerizer/mesos/isolators/network/port_mapping.hpp c14a8cca2b049104f3529b0c38c0ea6a5ccafe11
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 65b23f00a351d63bdf3fc315191946e9a69adfd6
src/slave/containerizer/mesos/isolators/network/ports.hpp c0d08589d32ffeb2d94c2f3db7added6b0cd36bf
src/slave/containerizer/mesos/isolators/network/ports.cpp fec74d3f47b033a402649658c0cef1ca92c76263
src/slave/containerizer/mesos/isolators/posix.hpp f8de3d2315554be3840911324ac645e21dfc04a0
src/slave/containerizer/mesos/isolators/posix/disk.hpp 2e9b48189d0b6b1a7def66414a58ccef5a1a66e3
src/slave/containerizer/mesos/isolators/posix/disk.cpp 4d8047b1f5966428911d095c734a0155b1f5148a
src/slave/containerizer/mesos/isolators/windows/cpu.hpp ef58d67c119fea6ba492ed19a953cb767289a605
src/slave/containerizer/mesos/isolators/windows/cpu.cpp 0d3706f4a34a912aa49885a2811cdd0b818788fb
src/slave/containerizer/mesos/isolators/windows/mem.hpp 1c87764c4b0dc8caac928f0e592e2853c7cff67d
src/slave/containerizer/mesos/isolators/windows/mem.cpp 4fabb934df0398a44b3a20dcab237730a9218039
src/slave/containerizer/mesos/isolators/xfs/disk.hpp 16bb432d8529f9ced3794fdb08089398659fc09f
src/slave/containerizer/mesos/isolators/xfs/disk.cpp 1680a5923734a6b1a42b8288aa81c5179b206cba
src/tests/containerizer/isolator.hpp 5861b8b8abbba65c499aa57fbf489d0c74414a5b
src/tests/slave_tests.cpp fd4fd6bd1baca0e4521999d2c08e6eab78e57a4f
Diff: https://reviews.apache.org/r/71884/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 71884: Updated the `update()` method of isolator to
handle resource limits.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71884/#review219789
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Jan. 5, 2020, 2:02 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71884/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2020, 2:02 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10065
> https://issues.apache.org/jira/browse/MESOS-10065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the `update()` method of isolator to handle resource limits.
>
>
> Diffs
> -----
>
> include/mesos/slave/isolator.hpp 65893e176d34d72c7d05a064a3de91217ef769c9
> src/slave/containerizer/mesos/isolator.hpp a5586799c47edff9b9db4af70bfd43772bfb7da1
> src/slave/containerizer/mesos/isolator.cpp ac333984db5ef0a9fed412c19152edfa4183b0e4
> src/slave/containerizer/mesos/isolator_tracker.hpp 563db10a5bfb78b5476100ec430ede69bdb02b31
> src/slave/containerizer/mesos/isolator_tracker.cpp c78e883fa49069fbc4ca439e612b62adafa081d9
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 4bd3d6dad37dee031660c15e957cc36f63e21fcb
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b12b73d8e0161d448075378765e77867521de04e
> src/slave/containerizer/mesos/isolators/filesystem/linux.hpp e6fe688a247358f30bed0492ebd1baddac8809e8
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ab192305b53c829fbf6cbf6367ce1686507f9c3d
> src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 9db6ddd2d457956f3020a11ba73d96b35b0d8a15
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp dbf149ad9c8fb900bb3b56f6e90b3a8643097d25
> src/slave/containerizer/mesos/isolators/gpu/isolator.hpp cc3cab51f7dab4393b101aff8b481a5cd0a01af9
> src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 5d1821087491cedd0cfbec5d57340bd927aae725
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp c14a8cca2b049104f3529b0c38c0ea6a5ccafe11
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 65b23f00a351d63bdf3fc315191946e9a69adfd6
> src/slave/containerizer/mesos/isolators/network/ports.hpp c0d08589d32ffeb2d94c2f3db7added6b0cd36bf
> src/slave/containerizer/mesos/isolators/network/ports.cpp fec74d3f47b033a402649658c0cef1ca92c76263
> src/slave/containerizer/mesos/isolators/posix.hpp f8de3d2315554be3840911324ac645e21dfc04a0
> src/slave/containerizer/mesos/isolators/posix/disk.hpp 2e9b48189d0b6b1a7def66414a58ccef5a1a66e3
> src/slave/containerizer/mesos/isolators/posix/disk.cpp 4d8047b1f5966428911d095c734a0155b1f5148a
> src/slave/containerizer/mesos/isolators/windows/cpu.hpp ef58d67c119fea6ba492ed19a953cb767289a605
> src/slave/containerizer/mesos/isolators/windows/cpu.cpp 0d3706f4a34a912aa49885a2811cdd0b818788fb
> src/slave/containerizer/mesos/isolators/windows/mem.hpp 1c87764c4b0dc8caac928f0e592e2853c7cff67d
> src/slave/containerizer/mesos/isolators/windows/mem.cpp 4fabb934df0398a44b3a20dcab237730a9218039
> src/slave/containerizer/mesos/isolators/xfs/disk.hpp 16bb432d8529f9ced3794fdb08089398659fc09f
> src/slave/containerizer/mesos/isolators/xfs/disk.cpp 1680a5923734a6b1a42b8288aa81c5179b206cba
> src/tests/containerizer/isolator.hpp 5861b8b8abbba65c499aa57fbf489d0c74414a5b
> src/tests/slave_tests.cpp fd4fd6bd1baca0e4521999d2c08e6eab78e57a4f
>
>
> Diff: https://reviews.apache.org/r/71884/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71884: Updated the `update()` method of isolator to
handle resource limits.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71884/
-----------------------------------------------------------
(Updated March 16, 2020, 5:05 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Rebased.
Bugs: MESOS-10065
https://issues.apache.org/jira/browse/MESOS-10065
Repository: mesos
Description
-------
Updated the `update()` method of isolator to handle resource limits.
Diffs (updated)
-----
include/mesos/slave/isolator.hpp 65893e176d34d72c7d05a064a3de91217ef769c9
src/slave/containerizer/mesos/isolator.hpp a5586799c47edff9b9db4af70bfd43772bfb7da1
src/slave/containerizer/mesos/isolator.cpp ac333984db5ef0a9fed412c19152edfa4183b0e4
src/slave/containerizer/mesos/isolator_tracker.hpp 563db10a5bfb78b5476100ec430ede69bdb02b31
src/slave/containerizer/mesos/isolator_tracker.cpp c78e883fa49069fbc4ca439e612b62adafa081d9
src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 8718b7a40640aed284b91891321b0f69fd38b40e
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp bf2a4d8d587969568f451f63e4f619e9c49f3642
src/slave/containerizer/mesos/isolators/filesystem/linux.hpp e6fe688a247358f30bed0492ebd1baddac8809e8
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 0819738a4770d4db0450f9fd3453d6d39f7ac3ff
src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 9db6ddd2d457956f3020a11ba73d96b35b0d8a15
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp dbf149ad9c8fb900bb3b56f6e90b3a8643097d25
src/slave/containerizer/mesos/isolators/gpu/isolator.hpp cc3cab51f7dab4393b101aff8b481a5cd0a01af9
src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 5d1821087491cedd0cfbec5d57340bd927aae725
src/slave/containerizer/mesos/isolators/network/port_mapping.hpp c14a8cca2b049104f3529b0c38c0ea6a5ccafe11
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 65b23f00a351d63bdf3fc315191946e9a69adfd6
src/slave/containerizer/mesos/isolators/network/ports.hpp c0d08589d32ffeb2d94c2f3db7added6b0cd36bf
src/slave/containerizer/mesos/isolators/network/ports.cpp 86d3053350651f2616f0574b4e03b0a60ef7d903
src/slave/containerizer/mesos/isolators/posix.hpp f8de3d2315554be3840911324ac645e21dfc04a0
src/slave/containerizer/mesos/isolators/posix/disk.hpp 2e9b48189d0b6b1a7def66414a58ccef5a1a66e3
src/slave/containerizer/mesos/isolators/posix/disk.cpp 842facf40fec776f06d44c4e605c94f1b7d4546e
src/slave/containerizer/mesos/isolators/windows/cpu.hpp ef58d67c119fea6ba492ed19a953cb767289a605
src/slave/containerizer/mesos/isolators/windows/cpu.cpp 0d3706f4a34a912aa49885a2811cdd0b818788fb
src/slave/containerizer/mesos/isolators/windows/mem.hpp 1c87764c4b0dc8caac928f0e592e2853c7cff67d
src/slave/containerizer/mesos/isolators/windows/mem.cpp 4fabb934df0398a44b3a20dcab237730a9218039
src/slave/containerizer/mesos/isolators/xfs/disk.hpp 16bb432d8529f9ced3794fdb08089398659fc09f
src/slave/containerizer/mesos/isolators/xfs/disk.cpp 1680a5923734a6b1a42b8288aa81c5179b206cba
src/tests/containerizer/isolator.hpp 5861b8b8abbba65c499aa57fbf489d0c74414a5b
src/tests/slave_tests.cpp 92fa2996f0e39dded79aa372ddf2390b68b885a2
Diff: https://reviews.apache.org/r/71884/diff/3/
Changes: https://reviews.apache.org/r/71884/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 71884: Updated the `update()` method of isolator to
handle resource limits.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71884/
-----------------------------------------------------------
(Updated Jan. 5, 2020, 10:02 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Changed the `resourcelimits` parameter to not use `Option`.
Bugs: MESOS-10065
https://issues.apache.org/jira/browse/MESOS-10065
Repository: mesos
Description
-------
Updated the `update()` method of isolator to handle resource limits.
Diffs (updated)
-----
include/mesos/slave/isolator.hpp 65893e176d34d72c7d05a064a3de91217ef769c9
src/slave/containerizer/mesos/isolator.hpp a5586799c47edff9b9db4af70bfd43772bfb7da1
src/slave/containerizer/mesos/isolator.cpp ac333984db5ef0a9fed412c19152edfa4183b0e4
src/slave/containerizer/mesos/isolator_tracker.hpp 563db10a5bfb78b5476100ec430ede69bdb02b31
src/slave/containerizer/mesos/isolator_tracker.cpp c78e883fa49069fbc4ca439e612b62adafa081d9
src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 4bd3d6dad37dee031660c15e957cc36f63e21fcb
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b12b73d8e0161d448075378765e77867521de04e
src/slave/containerizer/mesos/isolators/filesystem/linux.hpp e6fe688a247358f30bed0492ebd1baddac8809e8
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ab192305b53c829fbf6cbf6367ce1686507f9c3d
src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 9db6ddd2d457956f3020a11ba73d96b35b0d8a15
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp dbf149ad9c8fb900bb3b56f6e90b3a8643097d25
src/slave/containerizer/mesos/isolators/gpu/isolator.hpp cc3cab51f7dab4393b101aff8b481a5cd0a01af9
src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 5d1821087491cedd0cfbec5d57340bd927aae725
src/slave/containerizer/mesos/isolators/network/port_mapping.hpp c14a8cca2b049104f3529b0c38c0ea6a5ccafe11
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 65b23f00a351d63bdf3fc315191946e9a69adfd6
src/slave/containerizer/mesos/isolators/network/ports.hpp c0d08589d32ffeb2d94c2f3db7added6b0cd36bf
src/slave/containerizer/mesos/isolators/network/ports.cpp fec74d3f47b033a402649658c0cef1ca92c76263
src/slave/containerizer/mesos/isolators/posix.hpp f8de3d2315554be3840911324ac645e21dfc04a0
src/slave/containerizer/mesos/isolators/posix/disk.hpp 2e9b48189d0b6b1a7def66414a58ccef5a1a66e3
src/slave/containerizer/mesos/isolators/posix/disk.cpp 4d8047b1f5966428911d095c734a0155b1f5148a
src/slave/containerizer/mesos/isolators/windows/cpu.hpp ef58d67c119fea6ba492ed19a953cb767289a605
src/slave/containerizer/mesos/isolators/windows/cpu.cpp 0d3706f4a34a912aa49885a2811cdd0b818788fb
src/slave/containerizer/mesos/isolators/windows/mem.hpp 1c87764c4b0dc8caac928f0e592e2853c7cff67d
src/slave/containerizer/mesos/isolators/windows/mem.cpp 4fabb934df0398a44b3a20dcab237730a9218039
src/slave/containerizer/mesos/isolators/xfs/disk.hpp 16bb432d8529f9ced3794fdb08089398659fc09f
src/slave/containerizer/mesos/isolators/xfs/disk.cpp 1680a5923734a6b1a42b8288aa81c5179b206cba
src/tests/containerizer/isolator.hpp 5861b8b8abbba65c499aa57fbf489d0c74414a5b
src/tests/slave_tests.cpp fd4fd6bd1baca0e4521999d2c08e6eab78e57a4f
Diff: https://reviews.apache.org/r/71884/diff/2/
Changes: https://reviews.apache.org/r/71884/diff/1-2/
Testing
-------
Thanks,
Qian Zhang