You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/24 13:38:10 UTC

[GitHub] [airflow] kaxil commented on issue #7008: [AIRFLOW-6402] fix ssh_operator default value

kaxil commented on issue #7008: [AIRFLOW-6402] fix ssh_operator default value
URL: https://github.com/apache/airflow/pull/7008#issuecomment-590323584
 
 
   > this operator raises exception if no command is provided:
   > https://github.com/apache/airflow/blob/49845787feda26681456a56bf3fa11d3a1cb5cdf/airflow/contrib/operators/ssh_operator.py#L108-L109
   > 
   > does it make sense to just pass empty string `super().__init__(command='')` when subclassing?
   > 
   > seems like it would make sense to make `command` not optional i.e. remove the default value of `None`
   
   Yes, I don't see why someone would use SSHOperator without a "command". 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services