You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by apirom9 <gi...@git.apache.org> on 2018/10/30 15:58:18 UTC
[GitHub] commons-lang pull request #379: add tests for use ImmutableTriple as key in ...
GitHub user apirom9 opened a pull request:
https://github.com/apache/commons-lang/pull/379
add tests for use ImmutableTriple as key in java.util.HashMap and java.util.TreeMap
add tests for use ImmutableTriple as key in java.util.HashMap and java.util.TreeMap
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apirom9/commons-lang tasks/add-tests-for-immutable-triple
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/379.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #379
----
commit e4e92570188763170f9291f62cd388e7e5b9d119
Author: Apirom Na Nakorn <ap...@...>
Date: 2018-10-30T15:28:31Z
add test use ImmutablePair class with java.util.HashMap and java.util.TreeMap
commit 093fcf5eb346f0c02410fe2cd14d3c5aa494c3a0
Author: Apirom Na Nakorn <ap...@...>
Date: 2018-10-30T15:41:40Z
format code correctly based on error from Travis CI
commit 14f09339452883d0ceb70e8b1b2c82fe80660fe6
Author: Apirom Na Nakorn <ap...@...>
Date: 2018-10-30T15:42:41Z
Remove unused space
commit ae30de532507099132911e3952ad8e2568d3b219
Author: Apirom Na Nakorn <ap...@...>
Date: 2018-10-30T15:53:53Z
add test use ImmutableTriple class with java.util.HashMap and java.util.TreeMap
commit 29937f04c6de046ca3456305cdaece81a913b73b
Author: Apirom Na Nakorn <ap...@...>
Date: 2018-10-30T15:56:06Z
Remove unused space
----
---
[GitHub] commons-lang issue #379: add tests for use ImmutableTriple as key in java.ut...
Posted by apirom9 <gi...@git.apache.org>.
Github user apirom9 commented on the issue:
https://github.com/apache/commons-lang/pull/379
@kinow Yes, it is. Sorry for my mistake, I already close pull request #378
Thank you
Apirom
---
[GitHub] commons-lang issue #379: add tests for use ImmutableTriple as key in java.ut...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/379
[](https://coveralls.io/builds/19807783)
Coverage remained the same at 95.233% when pulling **29937f04c6de046ca3456305cdaece81a913b73b on apirom9:tasks/add-tests-for-immutable-triple** into **0fcd4ce92ad860a47ae85b1fc7b7e5cd35c8738e on apache:master**.
---
[GitHub] commons-lang issue #379: add tests for use ImmutableTriple as key in java.ut...
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/379
@apirom9 does this pull request number #379 supersedes yours previous one, number #378? It looks to me like the tests from #378 are present in this pull request too? If so then we should close #378 to avoid confusion when reviewing & merging.
Thanks
Bruno
---