[GitHub] [superset] zhaoyongjie edited a comment on pull request #18080: feat: smart tooltip in datasourcepanel

[GitBox <gi...@apache.org>]

zhaoyongjie edited a comment on pull request #18080:
URL: https://github.com/apache/superset/pull/18080#issuecomment-1021805602


   > > > @zhaoyongjie One thing that I found weird was that when the text is not truncated and I hover a column, for example, I get the original column name but when the text is truncated I only get the verbose name. I was expecting to see both the original column name and the verbose name. This applies to both columns and metrics.
   > > 
   > > 
   > > Hi @michael-s-molina, If a column has a verbose name and it is **un-truncated,** it will show `column name`. if a column has a verbose name and it **truncated**, it will show `un-truncated verbose name`
   > > Currently, tooltip just show **verbose name** or **database column name**, not both.
   > 
   > I think they are different information and both should be present. One thing is to see the original column name which is important and should always be visible. Another thing is to see the full truncated text which should display if the text gets truncated.
   > 
   > Here's one example:
   > 
   >     * I have a column with the name `Job Location Preference According to the National Job Department `
   > 
   >     * The original column name is `job_location_preference`
   > 
   > 
   > As the name will get truncated, the tooltip would display:
   > 
   >     * verbose name: Job Location Preference According to the National Job Department
   > 
   >     * column name: job_location_preference
   
   I know these different identifiers. Currently, only **1** name shown in the tooltip. let me list all the possibilities
   
   1. `short column name` without `verbose name`: **don't show tooltip**
   2. `long column name` without `verbose name`: **column name in tooltip**
   3. `(long or short) column name` with `short verbose name`: **column name in tooltip**
   4. `(long or short) column name` with `long verbose name`: **verbose name in tooltip**
   
   The major discussion is **4**. How to display tooltip when a column with a truncated verbose name. What do you think @geido @rusackas 
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org