You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/09 05:57:38 UTC

[GitHub] [beam] thetorpedodog commented on a change in pull request #11359: [BEAM-9731] Include more detail in passert.Equals errors.

thetorpedodog commented on a change in pull request #11359: [BEAM-9731] Include more detail in passert.Equals errors.
URL: https://github.com/apache/beam/pull/11359#discussion_r405972252
 
 

 ##########
 File path: sdks/go/pkg/beam/testing/passert/passert.go
 ##########
 @@ -32,29 +32,6 @@ import (
 //go:generate starcgen --package=passert --identifiers=diffFn,failFn,failKVFn,failGBKFn,hashFn,sumFn
 
 Review comment:
   do i need to add something here (or add a similar stanza to the new equals.go file)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services