You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2023/06/16 10:15:15 UTC
[GitHub] [spark] cloud-fan commented on a diff in pull request #41564: [SPARK-44025][SQL] Fix CSV Table Read Error with CharType(length) column
cloud-fan commented on code in PR #41564:
URL: https://github.com/apache/spark/pull/41564#discussion_r1232061666
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala:
##########
@@ -52,9 +52,6 @@ class UnivocityParser(
requiredSchema: StructType,
val options: CSVOptions,
filters: Seq[Filter]) extends Logging {
- require(requiredSchema.toSet.subsetOf(dataSchema.toSet),
Review Comment:
I don't think it's correct to just remove the check. We need to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org