[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6449: fs/unionfs: Don't unlink the source path

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #6449:
URL: https://github.com/apache/incubator-nuttx/pull/6449#discussion_r898872017


##########
fs/unionfs/fs_unionfs.c:
##########
@@ -2700,16 +2700,6 @@ static int unionfs_dobind(FAR const char *fspath1, FAR const char *prefix1,
         }
     }
 
-  /* Unlink the contained mountpoint inodes from the pseudo file system.
-   * The inodes will be marked as deleted so that they will be removed when
-   * the reference count decrements to zero in inode_release().  Because we
-   * hold a reference count on the inodes, they will not be deleted until
-   * this logic calls inode_release() in the unionfs_destroy() function.
-   */
-
-  inode_remove(fspath1);
-  inode_remove(fspath2);

Review Comment:
   After more discussion, unionfs just support the mount point now, so let me close this PR until we support to mount the normal path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org