You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/29 10:30:46 UTC

[GitHub] [incubator-shardingsphere] llk984145406 opened a new pull request #4532: add unit test for YamlOrchestrationConfiguration

llk984145406 opened a new pull request #4532: add unit test for YamlOrchestrationConfiguration
URL: https://github.com/apache/incubator-shardingsphere/pull/4532
 
 
   Fixes #ISSUSE_ID.
   For  #4439
   Changes proposed in this pull request:
   -
   -
   -
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] llk984145406 closed pull request #4532: add unit test for YamlOrchestrationConfiguration

Posted by GitBox <gi...@apache.org>.
llk984145406 closed pull request #4532: add unit test for YamlOrchestrationConfiguration
URL: https://github.com/apache/incubator-shardingsphere/pull/4532
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] nancyzrh removed a comment on issue #4532: add unit test for YamlOrchestrationConfiguration

Posted by GitBox <gi...@apache.org>.
nancyzrh removed a comment on issue #4532: add unit test for YamlOrchestrationConfiguration
URL: https://github.com/apache/incubator-shardingsphere/pull/4532#issuecomment-592930910
 
 
   /run tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on issue #4532: add unit test for YamlOrchestrationConfiguration

Posted by GitBox <gi...@apache.org>.
dongzl commented on issue #4532: add unit test for YamlOrchestrationConfiguration
URL: https://github.com/apache/incubator-shardingsphere/pull/4532#issuecomment-593056092
 
 
   Thanks for your contribution, Please fix CI problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] menghaoranss commented on issue #4532: add unit test for YamlOrchestrationConfiguration

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #4532: add unit test for YamlOrchestrationConfiguration
URL: https://github.com/apache/incubator-shardingsphere/pull/4532#issuecomment-593102084
 
 
   @llk984145406 , there are 2 errors about checkstyle, please fix them: 
   ```
   src/test/java/org/apache/shardingsphere/orchestration/center/yaml/config/YamlOrchestrationConfigurationTest.java:[5] (whitespace) EmptyLineSeparator: 'import' has more than 1 empty lines before.
   
   src/test/java/org/apache/shardingsphere/orchestration/center/yaml/config/YamlOrchestrationConfigurationTest.java:[5] (imports) CustomImportOrder: 'org.junit.Test' should be separated from previous import group by one line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] nancyzrh commented on issue #4532: add unit test for YamlOrchestrationConfiguration

Posted by GitBox <gi...@apache.org>.
nancyzrh commented on issue #4532: add unit test for YamlOrchestrationConfiguration
URL: https://github.com/apache/incubator-shardingsphere/pull/4532#issuecomment-592930910
 
 
   /run tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services