[GitHub] egor-ryashin commented on a change in pull request #6702: Add SelfDiscoveryResource

[GitBox <gi...@apache.org>]

egor-ryashin commented on a change in pull request #6702: Add SelfDiscoveryResource
URL: https://github.com/apache/incubator-druid/pull/6702#discussion_r243567387
 
 

 ##########
 File path: docs/content/operations/api-reference.md
 ##########
 @@ -54,6 +54,13 @@ An endpoint that always returns a boolean "true" value with a 200 OK response, u
 
 Returns the current configuration properties of the node.
 
+* `/selfDiscovered`
+
+Returns a JSON map of the form `{"selfDiscovered": true/false}`, indicating whether the node has recieved a confirmation
+from the central node discovery mechanism (currently ZooKeeper) of the Druid cluster that the node has been added to the
+cluster. It is recommended to not consider a Druid node "healthy" or "ready" in automated deployment/container
 
 Review comment:
   > It is recommended to not consider a Druid node "healthy" or "ready" in automated deployment/container
   management systems until it returns {"selfDiscovered": true} from this endpoint.
   
   Please, describe why it's not safe, probably with an example scenario.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org