You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by as...@apache.org on 2026/08/21 18:56:42 UTC

(maka) branch fix/chat-bubble-radius-astryx-default created (now 1a99e766e)

This is an automated email from the ASF dual-hosted git repository.

Astro-Han pushed a change to branch fix/chat-bubble-radius-astryx-default
in repository https://gitbox.apache.org/repos/asf/maka.git


      at 1a99e766e fix(ui): stop overriding Astryx's chat bubble radius

This branch includes the following new commits:

     new 1a99e766e fix(ui): stop overriding Astryx's chat bubble radius

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


(maka) 01/01: fix(ui): stop overriding Astryx's chat bubble radius

Posted by as...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

Astro-Han pushed a commit to branch fix/chat-bubble-radius-astryx-default
in repository https://gitbox.apache.org/repos/asf/maka.git

commit 1a99e766ef824bc69d0f5a2548df6257c7cc1084
Author: AstroHan <le...@outlook.com>
AuthorDate: Sat Aug 22 02:56:31 2026 +0800

    fix(ui): stop overriding Astryx's chat bubble radius
    
    `ChatMessageBubble` resolves `border-radius: var(--radius-chat)` (28px), the
    same token `ChatComposer` reads through `--_chat-composer-radius`. Bubble and
    composer are designed to round together as one conversation surface.
    
    The product diverged from that twice. `density="compact"` on both
    `ChatMessageList` instances swapped the bubble's radius for
    `var(--radius-container)` (12px), and `.maka-chat-message-bubble-user` then
    pushed the filled bubble down to `var(--radius-surface)` (10px). The composer
    was never overridden, so it kept rendering at 28px — a transcript and a dock
    on the same surface differing by nearly 3x.
    
    Remove both overrides rather than introduce a third value. 28px is what the
    primitive picks on its own once the product stops arguing with it.
    
    Dropping `density="compact"` also moves `ChatMessage`'s children gap from 2px
    to 4px, which is the tier's own spacing and comes bundled with it. Bubble
    padding is unaffected: Astryx's `paddingCompact` and `paddingBalanced` resolve
    to the same StyleX atoms.
    
    DESIGN.md §6 moves in the same commit so the document does not contradict the
    code: chat bubbles leave the 10px card row, a 28px chat rung records what
    `--radius-chat` governs, and the Two-Name Rule no longer claims that no product
    consumer renders at 28px.
    
    Generated-by: Claude Code
---
 DESIGN.md                                         |  5 +++--
 apps/desktop/src/renderer/styles/chat-message.css | 27 ++++++++++-------------
 packages/ui/src/chat-view.tsx                     |  2 --
 3 files changed, 15 insertions(+), 19 deletions(-)

diff --git a/DESIGN.md b/DESIGN.md
index 7eaceec02..30ef7a682 100644
--- a/DESIGN.md
+++ b/DESIGN.md
@@ -126,11 +126,12 @@ Nothing interactive is square. One ladder, assigned monotonically by box height:
 | Radius | Maka tier | Astryx tier | Assign to |
 |---|---|---|---|
 | 6px | control | inner | chips, keycaps, nested inlays, and product-drawn compact controls |
-| 10px | card | element | cards, rows-as-cards, list containers, chat bubbles; Astryx `Button`, `Input`, `SegmentedControl` |
+| 10px | card | element | cards, rows-as-cards, list containers; Astryx `Button`, `Input`, `SegmentedControl` |
 | 12px | container | container | modals, panels, portal surfaces; Astryx `Card`, `Dialog`, `DropdownMenu` |
+| 28px | chat | chat | the conversation surface as one shape: user bubble, assistant bubble, composer dock. Sourced from Astryx's `--radius-chat` by `ChatMessageBubble` and `ChatComposer` themselves; product CSS never restates it |
 | full | pill (999px) | full (9999px) | badges, pills, circular controls |
 
-- **The Two-Name Rule.** These are one ladder under two vocabularies, and the names never line up: Maka's `control` is Astryx's `inner`, Maka's `card` is Astryx's `element`, Maka's `modal` is Astryx's `container`. Resolve a tier from the box, never from the token name that sounds right. The paired values agree *today* but are independent literals, not aliases — an Astryx upgrade can move one side silently, so a mismatch is a real failure mode rather than an impossibility. Astryx's `--rad [...]
+- **The Two-Name Rule.** These are one ladder under two vocabularies, and the names never line up: Maka's `control` is Astryx's `inner`, Maka's `card` is Astryx's `element`, Maka's `modal` is Astryx's `container`. Resolve a tier from the box, never from the token name that sounds right. The paired values agree *today* but are independent literals, not aliases — an Astryx upgrade can move one side silently, so a mismatch is a real failure mode rather than an impossibility. The chat rung i [...]
 - **The Full-Bleed Rule.** `border-radius: 0` is legal only on true full-bleed rows — an element flush with its container on both sides. Radius and gap move together: if it has breathing room, it has corners.
 - **Proportional marks.** Product-drawn icon plates use ratio-owned radius (~25–27% of the box edge), recorded in prose because Stitch accepts only absolute units.
 
diff --git a/apps/desktop/src/renderer/styles/chat-message.css b/apps/desktop/src/renderer/styles/chat-message.css
index d9c12e890..fcb71e4d8 100644
--- a/apps/desktop/src/renderer/styles/chat-message.css
+++ b/apps/desktop/src/renderer/styles/chat-message.css
@@ -62,26 +62,23 @@
   font: var(--maka-text-body);
 }
 
-/* Padding and max-width belong to ChatMessageBubble; re-declaring those here
-   only forks the primitive. What stays is the product tint, the verbatim-text
-   rule (Maka renders user input as typed, which the primitive has no opinion
-   about) — and, since Visual System 2.0 (T3), the radius TIER.
-
-   The primitive resolves `--radius-container` (12px). DESIGN.md §6 assigns
-   radius by box height, and container is scoped to "modals, panels, portal
-   surfaces" — a message bubble is none of those. Measured in the chat fixture
-   the filled user bubble is 44px tall, which lands it in the card tier (10px,
-   "cards, rows-as-cards, list containers"). Astryx publishes no radius prop on
-   this component (only `variant`), so the tier is expressed on Maka's own
-   class rather than by reaching into the primitive's internals.
+/* Padding, max-width and radius belong to ChatMessageBubble; re-declaring any
+   of them here only forks the primitive. What stays is the product tint and the
+   verbatim-text rule (Maka renders user input as typed, which the primitive has
+   no opinion about).
+
+   Radius is absent on purpose. The primitive resolves `--radius-chat` (28px),
+   the same token `ChatComposer` reads through `--_chat-composer-radius`, so the
+   bubble and the dock round together as one conversation surface — DESIGN.md §6
+   records that as the chat rung. Astryx publishes no radius prop on this
+   component (only `variant`), so a product radius could only fight the
+   primitive, never configure it.
 
    Scoped to the filled bubble on purpose: the assistant bubble is `ghost` (no
-   fill, measured transparent), so it has no corner to round and inherits
-   nothing it needs to override. */
+   fill, measured transparent), so it carries no tint to override. */
 .maka-chat-message-bubble-user {
   background: var(--chat-user-bg);
   color: var(--chat-user-foreground, var(--foreground));
-  border-radius: var(--radius-surface);
   white-space: pre-wrap;
 }
 
diff --git a/packages/ui/src/chat-view.tsx b/packages/ui/src/chat-view.tsx
index 6d1358e9c..43b333673 100644
--- a/packages/ui/src/chat-view.tsx
+++ b/packages/ui/src/chat-view.tsx
@@ -483,7 +483,6 @@ export function ChatView(props: {
             owns. */}
         <ChatMessageList
           className="maka-chat-message-list maka-chatContent"
-          density="compact"
           gap={4}
           emptyState={conversationItems.length === 0 ? emptyContent : undefined}
         >
@@ -589,7 +588,6 @@ export function ChatView(props: {
         <ChatMessageList
           className="maka-chat-message-list maka-chatContent"
           data-turn-source-count={turns.length}
-          density="compact"
           gap={4}
           isStreaming={streamingActive}
           emptyState={showEmptyState ? emptyContent : undefined}


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org