You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/12/06 09:41:21 UTC

[GitHub] [ignite-3] AMashenkov commented on pull request #468: IGNITE-15885 Implement RocksDB-based Sorted Index Storage

AMashenkov commented on pull request #468:
URL: https://github.com/apache/ignite-3/pull/468#issuecomment-986603431


   I've see 3 similar interfaces. SearchRow, DataRow, IndexKey.
   PartitionStorage methods contract looks easy to understand,  
   ```
   DataRow read(SearchRow)
   void write(DataRow)
   ```
   however, SortedIndexStorage barely readable
   ```
   SearchRow get(IndexKey key)
   void put(IndexKey key, SearchRow value);
   ```
   
   Maybe it will be better to rename SearchRow -> KeyRow, IndexKey -> SearchRow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org