You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "Abhitocode (via GitHub)" <gi...@apache.org> on 2024/12/23 15:11:20 UTC
[PR] [Incubator kie issues#1723] Allow dot character in metadata attributes [incubator-kie-tools]
Abhitocode opened a new pull request, #2828:
URL: https://github.com/apache/incubator-kie-tools/pull/2828
As a result of the work in https://github.com/apache/incubator-kie-kogito-runtimes/pull/3740, the jbpm.enable.multi.con flag needs to be defines as process metadata attribute. However, the process designer does not allow the dot (.) character in the name of metadata attributes.
In order for users to define this process metadata attribute in the designer, it needs to be renamed in the engine, using only allowed characters.
Closes: https://github.com/apache/incubator-kie-issues/issues/1723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [kie-issues#1723] Allow dot character in metadata attributes [incubator-kie-tools]
Posted by "Abhitocode (via GitHub)" <gi...@apache.org>.
Abhitocode commented on PR #2828:
URL: https://github.com/apache/incubator-kie-tools/pull/2828#issuecomment-2585057780
@jomarko Thank you for the confirmation and the steps : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [kie-issues#1723] Allow dot character in metadata attributes [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on PR #2828:
URL: https://github.com/apache/incubator-kie-tools/pull/2828#issuecomment-2582439799
@Abhitocode Thank you, no worries. Please contact me in private to tackle together the issues you're facing in your local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [kie-issues#1723] Allow dot character in metadata attributes [incubator-kie-tools]
Posted by "jomarko (via GitHub)" <gi...@apache.org>.
jomarko commented on code in PR #2828:
URL: https://github.com/apache/incubator-kie-tools/pull/2828#discussion_r1900658637
##########
packages/stunner-editors/kie-wb-common-stunner/kie-wb-common-stunner-sets/kie-wb-common-stunner-bpmn/kie-wb-common-stunner-bpmn-client/src/main/java/org/kie/workbench/common/stunner/bpmn/client/forms/util/StringUtils.java:
##########
@@ -36,6 +36,7 @@
public class StringUtils {
public static final String ALPHA_NUM_REGEXP = "^[a-zA-Z0-9\\-\\_]*$";
+ public static final String ALPHA_NUM_UNDERSCORE_DOT_REGEXP = "^[a-zA-Z0-9\\-\\_\\.]*$";
Review Comment:
Maybe we should reflect also `\\-` in the constant name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [kie-issues#1723] Allow dot character in metadata attributes [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on PR #2828:
URL: https://github.com/apache/incubator-kie-tools/pull/2828#issuecomment-2582046867
@Abhitocode is this ready to be reviewed, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [kie-issues#1723] Allow dot character in metadata attributes [incubator-kie-tools]
Posted by "jomarko (via GitHub)" <gi...@apache.org>.
jomarko commented on PR #2828:
URL: https://github.com/apache/incubator-kie-tools/pull/2828#issuecomment-2572655367
@Abhitocode thank you for pushed updates. Please let us know once the PR is done and ready for a review. Then we should convert it from a draft PR to regular PR to run all CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [kie-issues#1723] Allow dot character in metadata attributes [incubator-kie-tools]
Posted by "Abhitocode (via GitHub)" <gi...@apache.org>.
Abhitocode commented on code in PR #2828:
URL: https://github.com/apache/incubator-kie-tools/pull/2828#discussion_r1901876385
##########
packages/stunner-editors/kie-wb-common-stunner/kie-wb-common-stunner-sets/kie-wb-common-stunner-bpmn/kie-wb-common-stunner-bpmn-client/src/main/java/org/kie/workbench/common/stunner/bpmn/client/forms/util/StringUtils.java:
##########
@@ -36,6 +36,7 @@
public class StringUtils {
public static final String ALPHA_NUM_REGEXP = "^[a-zA-Z0-9\\-\\_]*$";
+ public static final String ALPHA_NUM_UNDERSCORE_DOT_REGEXP = "^[a-zA-Z0-9\\-\\_\\.]*$";
Review Comment:
Thank you for the suggestion @jomarko , yes it makes sense. I'll update that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [kie-issues#1723] Allow dot character in metadata attributes [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer merged PR #2828:
URL: https://github.com/apache/incubator-kie-tools/pull/2828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [kie-issues#1723] Allow dot character in metadata attributes [incubator-kie-tools]
Posted by "Abhitocode (via GitHub)" <gi...@apache.org>.
Abhitocode commented on PR #2828:
URL: https://github.com/apache/incubator-kie-tools/pull/2828#issuecomment-2582098702
Hi @yesamer @jomarko, apologies for the delay in reply as I was travelling and away from system. PR is ready but to note when I tried to test the same I had issues with building the editor, I have followed the steps, while `pnpm bootstrap` is successful but fails due to dependency issues when `mvn clean gwt:run` is run. Also tried building with .vsix approach. Not sure where Im missing. Since its a straight forward minor change I think we could merge it. Any suggestions from your side would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org