You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2020/02/27 02:11:48 UTC
[kudu-CR] [thirdparty] Update cmake to 3.16.4
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15303
Change subject: [thirdparty] Update cmake to 3.16.4
......................................................................
[thirdparty] Update cmake to 3.16.4
Cmake 3.9.0 was giving me the following error when compiling Thrift on macOS:
Boost 1.53 found.
Found Boost components:
system;thread;unit_test_framework;filesystem;chrono;program_options
CMake Error in /Users/mpercy/src/kudu/thirdparty/installed/common/share/cmake-3.9/Modules/FindBoost.cmake:
cmake_policy PUSH without matching POP
Call Stack (most recent call first):
build/cmake/DefineOptions.cmake:117 (find_package)
CMakeLists.txt:52 (include)
It's possible that it was a conflict on my local machine related to
having multiple versions of cmake installed (I also have version 3.15.3
in ~/.brew), but I'm not certain. Either way, this fixes the thrift
thirdparty compile for me on macOS.
Change-Id: Ic8c3c578aea0f45c1279302eedef2dc5a1f8e9e1
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/15303/1
--
To view, visit http://gerrit.cloudera.org:8080/15303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8c3c578aea0f45c1279302eedef2dc5a1f8e9e1
Gerrit-Change-Number: 15303
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] [thirdparty] Update cmake to 3.16.4
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15303 )
Change subject: [thirdparty] Update cmake to 3.16.4
......................................................................
Patch Set 1:
> > Alexey, have you seen any similar issues on macOS? I wonder if
> it's
> > my machine (I'm running Catalina w/ Xcode 11.3.0, if that
> matters).
> >
> > Anyway, the package that appears to work for me is at:
> > https://github.com/Kitware/CMake/releases/download/v3.16.4/cmake-3.16.4.tar.gz
> >
> > However I don't have the ability to upload that artifact to the
> S3
> > bucket, so if someone can do that then this patch should
> > successfully build.
>
> Nope, I haven't see anything like this on my macbook running MacOS
> High Sierra (10.13.6 build 17G11023). But my Xcode is of 10.1
> version.
As an additional piece of info, I also have alternative cmake installed from MacPorts: cmake version 3.16.4
--
To view, visit http://gerrit.cloudera.org:8080/15303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8c3c578aea0f45c1279302eedef2dc5a1f8e9e1
Gerrit-Change-Number: 15303
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 27 Feb 2020 19:19:29 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] Update cmake to 3.16.4
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15303 )
Change subject: [thirdparty] Update cmake to 3.16.4
......................................................................
Patch Set 1:
Thanks guys, I will dig in again and see if I can fix the issue locally.
--
To view, visit http://gerrit.cloudera.org:8080/15303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8c3c578aea0f45c1279302eedef2dc5a1f8e9e1
Gerrit-Change-Number: 15303
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 27 Feb 2020 23:47:28 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] Update cmake to 3.16.4
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change. ( http://gerrit.cloudera.org:8080/15303 )
Change subject: [thirdparty] Update cmake to 3.16.4
......................................................................
Abandoned
I removed thirdparty/common/bin from my PATH and now I'm able to build thirdparty on my Mac again. I'm not sure what caused this issue but since it's no longer a problem I'm going to abandon this CR.
--
To view, visit http://gerrit.cloudera.org:8080/15303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic8c3c578aea0f45c1279302eedef2dc5a1f8e9e1
Gerrit-Change-Number: 15303
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [thirdparty] Update cmake to 3.16.4
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15303 )
Change subject: [thirdparty] Update cmake to 3.16.4
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15303/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15303/1//COMMIT_MSG@11
PS1, Line 11: Boost 1.53 found.
: Found Boost components:
: system;thread;unit_test_framework;filesystem;chrono;program_options
: CMake Error in /Users/mpercy/src/kudu/thirdparty/installed/common/share/cmake-3.9/Modules/FindBoost.cmake:
: cmake_policy PUSH without matching POP
: Call Stack (most recent call first):
: build/cmake/DefineOptions.cmake:117 (find_package)
: CMakeLists.txt:52 (include)
This shouldn't be happening.
Here's the related code in Thrift's DefineOptions.cmake:
if(BUILD_CPP)
set(boost_components)
if(WITH_BOOSTTHREADS OR BUILD_TESTING)
list(APPEND boost_components system thread)
endif()
if(BUILD_TESTING)
list(APPEND boost_components unit_test_framework filesystem chrono program_options)
endif()
if(boost_components)
find_package(Boost 1.53 REQUIRED COMPONENTS ${boost_components})
endif()
elseif(BUILD_C_GLIB AND BUILD_TESTING)
find_package(Boost 1.53 REQUIRED)
endif()
And here's how we build Thrift:
# Thrift depends on bison.
#
# Configure for a very minimal install - only the C++ client libraries are needed.
# Thrift requires C++11 when compiled on Linux against libc++ (see cxxfunctional.h).
CFLAGS="$EXTRA_CFLAGS" \
CXXFLAGS="$EXTRA_CXXFLAGS -std=c++11" \
LDFLAGS="$EXTRA_LDFLAGS" \
LIBS="$EXTRA_LIBS" \
cmake \
-DBOOST_ROOT=$PREFIX \
-DBUILD_C_GLIB=OFF \
-DBUILD_COMPILER=ON \
-DBUILD_CPP=ON \
-DBUILD_EXAMPLES=OFF \
-DBUILD_HASKELL=OFF \
-DBUILD_JAVA=OFF \
-DBUILD_PYTHON=OFF \
-DBUILD_TESTING=OFF \
-DBUILD_TUTORIALS=OFF \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=$PREFIX \
-DWITH_BOOSTTHREADS=OFF \
-DWITH_LIBEVENT=OFF \
-DWITH_OPENSSL=OFF \
-DWITH_PLUGIN=OFF \
$EXTRA_CMAKE_FLAGS \
$THRIFT_SOURCE
So BUILD_CPP is ON, but WITH_BOOSTTHREADS and BUILD_TESTING are both OFF. Meaning, Thrift shouldn't be trying to build Boost at all, which makes sense, because the components in your build log aren't even provided by the Boost built by Kudu in thirdparty.
You should dig into the Thrift build log further to try to understand why it's attempting to build Boost.
--
To view, visit http://gerrit.cloudera.org:8080/15303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8c3c578aea0f45c1279302eedef2dc5a1f8e9e1
Gerrit-Change-Number: 15303
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 27 Feb 2020 04:51:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Update cmake to 3.16.4
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15303 )
Change subject: [thirdparty] Update cmake to 3.16.4
......................................................................
Patch Set 1:
> Alexey, have you seen any similar issues on macOS? I wonder if it's
> my machine (I'm running Catalina w/ Xcode 11.3.0, if that matters).
>
> Anyway, the package that appears to work for me is at:
> https://github.com/Kitware/CMake/releases/download/v3.16.4/cmake-3.16.4.tar.gz
>
> However I don't have the ability to upload that artifact to the S3
> bucket, so if someone can do that then this patch should
> successfully build.
Nope, I haven't see anything like this on my macbook running MacOS High Sierra (10.13.6 build 17G11023). But my Xcode is of 10.1 version.
--
To view, visit http://gerrit.cloudera.org:8080/15303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8c3c578aea0f45c1279302eedef2dc5a1f8e9e1
Gerrit-Change-Number: 15303
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 27 Feb 2020 19:18:24 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] Update cmake to 3.16.4
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15303 )
Change subject: [thirdparty] Update cmake to 3.16.4
......................................................................
Patch Set 1:
Alexey, have you seen any similar issues on macOS? I wonder if it's my machine (I'm running Catalina w/ Xcode 11.3.0, if that matters).
Anyway, the package that appears to work for me is at: https://github.com/Kitware/CMake/releases/download/v3.16.4/cmake-3.16.4.tar.gz
However I don't have the ability to upload that artifact to the S3 bucket, so if someone can do that then this patch should successfully build.
--
To view, visit http://gerrit.cloudera.org:8080/15303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8c3c578aea0f45c1279302eedef2dc5a1f8e9e1
Gerrit-Change-Number: 15303
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 27 Feb 2020 02:14:14 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] Update cmake to 3.16.4
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15303 )
Change subject: [thirdparty] Update cmake to 3.16.4
......................................................................
Patch Set 1:
> Thanks guys, I will dig in again and see if I can fix the issue
> locally.
It turns out we will need to update cmake anyways due to compilation issues if using OpenJDK 11. I'll post a patch soon. But it would be great to understand what it was it your case, yep.
--
To view, visit http://gerrit.cloudera.org:8080/15303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8c3c578aea0f45c1279302eedef2dc5a1f8e9e1
Gerrit-Change-Number: 15303
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 28 Feb 2020 01:25:36 +0000
Gerrit-HasComments: No