You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/11 14:53:47 UTC
[GitHub] [spark-docker] Yikun opened a new pull request, #6: [SPARK-40754][DOCS] Add LICENSE and NOTICE
Yikun opened a new pull request, #6:
URL: https://github.com/apache/spark-docker/pull/6
### What changes were proposed in this pull request?
This pach adds LICENSE and NOTICE:
- LICENSE: https://www.apache.org/licenses/LICENSE-2.0.txt
- NOTICE: https://github.com/apache/spark/blob/master/NOTICE
### Why are the changes needed?
https://www.apache.org/licenses/LICENSE-2.0#apply
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun commented on a diff in pull request #6: [SPARK-40754][DOCS] Add LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
Yikun commented on code in PR #6:
URL: https://github.com/apache/spark-docker/pull/6#discussion_r992924616
##########
NOTICE:
##########
@@ -0,0 +1,41 @@
+Apache Spark
+Copyright 2014 and onwards The Apache Software Foundation.
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+
+Export Control Notice
+---------------------
+
+This distribution includes cryptographic software. The country in which you currently reside may have
+restrictions on the import, possession, use, and/or re-export to another country, of encryption software.
+BEFORE using any encryption software, please check your country's laws, regulations and policies concerning
+the import, possession, or use, and re-export of encryption software, to see if this is permitted. See
+<http://www.wassenaar.org/> for more information.
+
+The U.S. Government Department of Commerce, Bureau of Industry and Security (BIS), has classified this
+software as Export Commodity Control Number (ECCN) 5D002.C.1, which includes information security software
+using or performing cryptographic functions with asymmetric algorithms. The form and manner of this Apache
+Software Foundation distribution makes it eligible for export under the License Exception ENC Technology
+Software Unrestricted (TSU) exception (see the BIS Export Administration Regulations, Section 740.13) for
+both object code and source code.
+
+The following provides more details on the included cryptographic software:
+
+This software uses Apache Commons Crypto (https://commons.apache.org/proper/commons-crypto/) to
+support authentication, and encryption and decryption of data sent across the network between
+services.
+
+
+Metrics
+Copyright 2010-2013 Coda Hale and Yammer, Inc.
Review Comment:
Agree!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun commented on pull request #6: [SPARK-40754][DOCS] Add LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #6:
URL: https://github.com/apache/spark-docker/pull/6#issuecomment-1277644448
@HyukjinKwon @srowen @tgravescs Thanks! Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] tgravescs commented on a diff in pull request #6: [SPARK-40754][DOCS] Add LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
tgravescs commented on code in PR #6:
URL: https://github.com/apache/spark-docker/pull/6#discussion_r992503225
##########
NOTICE:
##########
@@ -0,0 +1,41 @@
+Apache Spark
+Copyright 2014 and onwards The Apache Software Foundation.
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+
+Export Control Notice
+---------------------
+
+This distribution includes cryptographic software. The country in which you currently reside may have
+restrictions on the import, possession, use, and/or re-export to another country, of encryption software.
+BEFORE using any encryption software, please check your country's laws, regulations and policies concerning
+the import, possession, or use, and re-export of encryption software, to see if this is permitted. See
+<http://www.wassenaar.org/> for more information.
+
+The U.S. Government Department of Commerce, Bureau of Industry and Security (BIS), has classified this
+software as Export Commodity Control Number (ECCN) 5D002.C.1, which includes information security software
+using or performing cryptographic functions with asymmetric algorithms. The form and manner of this Apache
+Software Foundation distribution makes it eligible for export under the License Exception ENC Technology
+Software Unrestricted (TSU) exception (see the BIS Export Administration Regulations, Section 740.13) for
+both object code and source code.
+
+The following provides more details on the included cryptographic software:
+
+This software uses Apache Commons Crypto (https://commons.apache.org/proper/commons-crypto/) to
+support authentication, and encryption and decryption of data sent across the network between
+services.
+
+
+Metrics
+Copyright 2010-2013 Coda Hale and Yammer, Inc.
Review Comment:
I don't think we need the Coda Hale one in here since that source code isn't in this repo. Same thing for the crypto one I think. I think the NOTICE only applies to the source in the repo.
But its not clear to me how that applies to the binary generated from the docker file and what exactly needs to go into that docker file or in like. NOTICE-binary file. It would be good to ask Apache folks or see what other projects have done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] HyukjinKwon commented on pull request #6: [SPARK-40754][DOCS] Add LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #6:
URL: https://github.com/apache/spark-docker/pull/6#issuecomment-1277167376
cc @srowen FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun closed pull request #6: [SPARK-40754][DOCS] Add LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
Yikun closed pull request #6: [SPARK-40754][DOCS] Add LICENSE and NOTICE
URL: https://github.com/apache/spark-docker/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun commented on pull request #6: [SPARK-40754][DOCS] Add LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #6:
URL: https://github.com/apache/spark-docker/pull/6#issuecomment-1275502829
> But its not clear to me how that applies to the binary generated from the docker file and what exactly needs to go into that docker file or in like. NOTICE-binary file. It would be good to ask Apache folks or see what other projects have done.
We (I and Tom) had some initial discuss in here: https://github.com/apache/spark-docker/pull/2#issuecomment-1274772242 , let me show more invistigation here:
- `spark` (Docekr Official Image, DOI):
- it published by Docker community
- Docker community only required the dockerfile is under [an OSI-approved license](https://opensource.org/licenses) from [link](https://github.com/docker-library/official-images/blob/master/NEW-IMAGE-CHECKLIST.md)
- https://github.com/docker-library/official-images/pull/13089 is the PR for Apache Spark.
- For DOI, **Only LICENSE and NOTICE** needed, because it published in downstream.
- `apache/spark` (Apache Spark Official image)
- it published by Apache community
- [LEGAL-270](https://issues.apache.org/jira/browse/LEGAL-270): ASF allows dockerhub publish
> The main Docker Hub at hub.docker.com is a public-facing downstream distribution channel – similar to Maven Central, PyPI, Debian package management.
>
> Docker images can be built from our official source releases, but are derived distributions analogous to, say, Debian packages.
- [LEGAL-437](https://issues.apache.org/jira/browse/LEGAL-437): it might related to NOTICE-binary, but didn't get a clear results. However, according the ASF legal, leans to `Any components in the parent container are the responsibility of the parent container (ie: owner of <image> in FROM <image>) to comply` and `generally trusting top level Linux OS images`.
- Consider above two JIRAs, so I think `NOTICE-binary` will be same with `apache/spark` repo, or we can just reference https://github.com/apache/solr-docker, https://github.com/apache/flink-docker, only **LICENSE and NOTICE** is enough in here.
also cc @srowen (who create the LICENSE for apache/spark)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] HyukjinKwon commented on pull request #6: [SPARK-40754][DOCS] Add LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #6:
URL: https://github.com/apache/spark-docker/pull/6#issuecomment-1278392102
Thanks for driving this @Yikun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun commented on pull request #6: [SPARK-40754][DOCS] Add LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #6:
URL: https://github.com/apache/spark-docker/pull/6#issuecomment-1274831095
cc @tgravescs @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] tgravescs commented on pull request #6: [SPARK-40754][DOCS] Add LICENSE and NOTICE
Posted by GitBox <gi...@apache.org>.
tgravescs commented on PR #6:
URL: https://github.com/apache/spark-docker/pull/6#issuecomment-1277624242
Ok, seems that plan is fine based on other projects. Its to bad they didn't answer all the questions on LEGAL-437.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org