You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2013/04/04 11:59:16 UTC

[jira] [Resolved] (HTTPCLIENT-1336) Document Entity-consuming behaviour of HttpClient.execute methods with ResponseHandler param

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-1336.
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 4.3 Alpha2
                   4.2.4

Fixed in SVN trunk and 4.2.x branch.

http://svn.apache.org/r1464408

Feel free to improve on my changes and contribute a better description of the methods in question.

Olrh

                
> Document Entity-consuming behaviour of HttpClient.execute methods with ResponseHandler param
> --------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1336
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1336
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: Documentation, HttpClient
>    Affects Versions: 4.2.3
>            Reporter: Richard Barnett
>            Priority: Minor
>             Fix For: 4.2.4, 4.3 Alpha2
>
>
> AbstractHttpClient implementations of the HttpClient.execute methods with a ResponseHandler parameter consume the response entity:
>         HttpResponse response = execute(target, request, context);
>         T result;
>         try {
>             result = responseHandler.handleResponse(response);
>         } catch (Exception t) { ... }
>         HttpEntity entity = response.getEntity();
>         EntityUtils.consume(entity);
>         return result
> Document this in javadoc somewhere; probably either ResponseHandler or HttpClient.  (It's not clear whether this behaviour is part of the HttpClient interface contract for these execute methods.)
> (I hit this because I used one of these methods to work round HTTPCLIENT-1335.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org