[echarts] branch master updated: fix(custom): set ignore only if old child exists (#17450)

[ov...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ovilia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts.git


The following commit(s) were added to refs/heads/master by this push:
     new 715e1daee fix(custom): set ignore only if old child exists (#17450)
715e1daee is described below

commit 715e1daee0b660dfeb37e104a1a57325f46fbf70
Author: Wenli Zhang <zw...@gmail.com>
AuthorDate: Mon Aug 1 14:32:54 2022 +0800

    fix(custom): set ignore only if old child exists (#17450)
---
 src/chart/custom/CustomView.ts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/chart/custom/CustomView.ts b/src/chart/custom/CustomView.ts
index 215087b72..ad282ed9b 100644
--- a/src/chart/custom/CustomView.ts
+++ b/src/chart/custom/CustomView.ts
@@ -1340,6 +1340,13 @@ function mergeChildren(
             );
         }
         else {
+            if (__DEV__) {
+                assert(
+                    oldChild,
+                    'renderItem should not return a group containing elements'
+                    + ' as null/undefined/{} if they do not exist before.'
+                );
+            }
             // If the new element option is null, it means to remove the old
             // element. But we cannot really remove the element from the group
             // directly, because the element order may not be stable when this


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org