[Bug 7748] New: TVD_APPROVED too loose

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7748

            Bug ID: 7748
           Summary: TVD_APPROVED too loose
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Rules
          Assignee: dev@spamassassin.apache.org
          Reporter: s@stuartpb.com
  Target Milestone: Undefined

I had an important travel confirmation email filtered as spam under the
TVD_APPROVED rule for including these lines:

>> you will receive a separate email receipt after you are charged.
>>
>> TripIt Approved

The `/you.{1,2}re .{0,20}approved/i` test in
https://svn.apache.org/repos/asf/spamassassin/trunk/rulesrc/sandbox/felicity/70_other.cf
could probably be tightened to avoid false positives like this: maybe use
`[^\n]{0,20}` instead, so the test won't span unrelated lines?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7748] TVD_APPROVED too loose

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7748

Bill Cole <bi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |billcole@apache.org
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Bill Cole <bi...@apache.org> ---
Normally rule FPs are not considered bugs per se, since they it is expected
that spam rules will match on some ham and nice rules will match on some spam,
with the *AGGREGATE* scores being what matters. In principle, rules get
rescored algorithmically based on their quality as reported in masscheck
reports. HOWEVER, this rule inexplicably has been pegged at fairly high scores
for almost 10 years in 50_scores.cf, immune to RuleQA:

score TVD_APPROVED 2.356 2.599 2.599 2.090 # n=2

Current and recent RuleQA results cannot justify that, so I have removed the
fixed scores in r1865956. I expect the rule will be scored down on the next
rescoring run. 


Modifying the rule to not span lines would make it not match much of the spam
that it has matched in the past, so it is not clear that there would be any
point to a modified rule.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7748] TVD_APPROVED too loose

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7748

RW <rw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rwmaillists@googlemail.com

--- Comment #2 from RW <rw...@googlemail.com> ---
[^\n]{0,20} wont make any difference as body rules run against individual
paragraphs that have been flattened into a single line.

Presumably the '>>' quoting, or something similar, was in the original.
Otherwise it would be two paragraphs.

-- 
You are receiving this mail because:
You are the assignee for the bug.