[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2132: libxx: fix/suppresss warnings

[GitBox <gi...@apache.org>]

v01d commented on a change in pull request #2132:
URL: https://github.com/apache/incubator-nuttx/pull/2132#discussion_r512698479



##########
File path: libs/libxx/cxx.defs
##########
@@ -22,3 +22,14 @@ CXXSRCS += libxx_cxa_guard.cxx libxx_cxapurevirtual.cxx
 CXXSRCS += libxx_delete.cxx libxx_delete_sized.cxx libxx_deletea.cxx
 CXXSRCS += libxx_deletea_sized.cxx libxx_new.cxx libxx_newa.cxx
 CXXSRCS += libxx_stdthrow.cxx
+
+# Note: Our implmenetations of operator new are not conforming to
+# the standard. (no bad_alloc implementation)
+#
+# libxx_new.cxx:64:11: error: 'operator new' is missing exception specification
+#       'throw(std::bad_alloc)' [-Werror,-Wmissing-exception-spec]

Review comment:
       @yamt can you open an issue to remind ourselves to fix this? shouldn't be hard




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org