[GitHub] [calcite] risdenk commented on a change in pull request #1116: [CALCITE-2929] Simplification of IS NULL checks are incorrectly assum…

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #1116: [CALCITE-2929] Simplification of IS NULL checks are incorrectly assum…
URL: https://github.com/apache/calcite/pull/1116#discussion_r267410699
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
 ##########
 @@ -708,12 +708,15 @@ private RexNode simplifyIs2(SqlKind kind, RexNode a, RexUnknownAs unknownAs) {
   }
 
   private RexNode simplifyIsNotNull(RexNode a) {
-    if (!a.getType().isNullable()) {
+    if (!a.getType().isNullable() && isSafeExpression(a)) {
       return rexBuilder.makeLiteral(true);
     }
     if (predicates.pulledUpPredicates.contains(a)) {
 
 Review comment:
   I saw this conversation and assumed it wasn't blocking the merge of this change.
   
   @vlsi / @kgyrtkirk - If I was wrong and this should have held up the merge of this - please ping me. I have started the 1.19.0 RC2 process

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services