You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "mderoy (via GitHub)" <gi...@apache.org> on 2023/06/12 17:57:43 UTC
[GitHub] [iceberg] mderoy opened a new pull request, #7823: Fixes for D205 issues
mderoy opened a new pull request, #7823:
URL: https://github.com/apache/iceberg/pull/7823
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #7823: Python: Fixes for D205 issues
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #7823:
URL: https://github.com/apache/iceberg/pull/7823#issuecomment-1590605138
@mderoy Could you rebase? https://github.com/apache/iceberg/pull/7829 went just in and it looks it has a lot of conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #7823: Python: Fixes for D205 issues
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #7823:
URL: https://github.com/apache/iceberg/pull/7823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #7823: Python: Fixes for D205 issues
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #7823:
URL: https://github.com/apache/iceberg/pull/7823#discussion_r1229768086
##########
python/pyiceberg/utils/deprecated.py:
##########
@@ -20,9 +20,9 @@
def deprecated(deprecated_in: str, removed_in: str, help_message: Optional[str] = None) -> Callable: # type: ignore
- """
- This is a decorator which can be used to mark functions as deprecated.
- It will result in a warning being emitted when the function is used.
+ """A decorator which can be used to mark functions as depricated.
Review Comment:
```suggestion
"""A decorator which can be used to mark functions as deprecated.
```
##########
python/pyiceberg/utils/deprecated.py:
##########
@@ -20,9 +20,9 @@
def deprecated(deprecated_in: str, removed_in: str, help_message: Optional[str] = None) -> Callable: # type: ignore
- """
- This is a decorator which can be used to mark functions as deprecated.
- It will result in a warning being emitted when the function is used.
+ """A decorator which can be used to mark functions as depricated.
+
+ adding this will result in a warning being emitted when the function is used.
Review Comment:
```suggestion
Adding this will result in a warning being emitted when the function is used.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] mderoy commented on a diff in pull request #7823: Python: Fixes for D205 issues
Posted by "mderoy (via GitHub)" <gi...@apache.org>.
mderoy commented on code in PR #7823:
URL: https://github.com/apache/iceberg/pull/7823#discussion_r1228196620
##########
python/pyiceberg/conversions.py:
##########
@@ -109,6 +109,8 @@ def _(primitive_type: BooleanType, value_str: str) -> Union[int, float, str, uui
@handle_none
def _(primitive_type: PrimitiveType, value_str: str) -> int:
"""
+ Converts a string to an integer value
Review Comment:
whoops :) fixed with https://github.com/apache/iceberg/pull/7823/commits/d450891f870e94d59022ca0dbec79e1e667ba4fa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #7823: Fixes for D205 issues
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #7823:
URL: https://github.com/apache/iceberg/pull/7823#discussion_r1227261055
##########
python/pyiceberg/conversions.py:
##########
@@ -109,6 +109,8 @@ def _(primitive_type: BooleanType, value_str: str) -> Union[int, float, str, uui
@handle_none
def _(primitive_type: PrimitiveType, value_str: str) -> int:
"""
+ Converts a string to an integer value
Review Comment:
Shouldn't this one be one line up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] mderoy commented on pull request #7823: Python: Fixes for D205 issues
Posted by "mderoy (via GitHub)" <gi...@apache.org>.
mderoy commented on PR #7823:
URL: https://github.com/apache/iceberg/pull/7823#issuecomment-1591361164
> @mderoy Could you rebase? #7829 went just in and it looks it has a lot of conflicts
done :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org