You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/07/11 19:17:21 UTC

[GitHub] [incubator-gobblin] jhsenjaliya opened a new pull request #2685: Gobblin 822

jhsenjaliya opened a new pull request #2685: Gobblin 822
URL: https://github.com/apache/incubator-gobblin/pull/2685
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-822
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   log4j2 has routing appender that would be super useful and probably only way to achieve "job specific logging" functionality without meddling around fileHandler in log4j.
   Also log4j2 has lot of new functionalities and performance benefits
   ==NOTE== there are PRs that is not merged into master, hence we see some commit messages and changes from previous commits, that i have rebased to, once that PR is merged, those changes will go away from this PR.==
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: No new functionality added
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services