[GitHub] [zeppelin] Reamer commented on a change in pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

[GitBox <gi...@apache.org>]

Reamer commented on a change in pull request #4092:
URL: https://github.com/apache/zeppelin/pull/4092#discussion_r611652026



##########
File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java
##########
@@ -225,6 +228,8 @@ public void moveNote(String noteId,
       throw new IOException("No metadata found for this note: " + noteId);
     }
 
+    validateNotePathDoesNotExist(newNotePath);

Review comment:
       Just a style change:
   Please return a boolean value and do not throw the IOExecption out of the private method.
   ````
   if (! isNotePathUnused(newNotePath) {
      throw new IOException("Note '" + notePath + "' is already in use");
   }
   ````




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org