You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Venki Korukanti <ve...@gmail.com> on 2015/05/12 22:03:43 UTC
Review Request 34120: DRILL-2755: (part2) Use and handle
InterruptedException during query processing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34120/
-----------------------------------------------------------
Review request for drill and Jacques Nadeau.
Repository: drill-git
Description
-------
Initial patch [1] reports interrupts as failures in logs. This patch addresses the issues to report interrupt to RpcOutcomeListener. Handle the interrupt in RpcOutComeListener depending upon the implementation. Specific details of the handling are here [2]
[1] https://github.com/apache/drill/commit/3a294abcc51148e0e79096af5e6d3c45b7c19a9d
[2] Goto sheet "RpcOutcomeListener Impl" in https://docs.google.com/spreadsheets/d/1phC5f7E6jn1WN-wXVdUllbIQ2k7K2ZftZzDdhDNLgtg/edit?usp=sharing
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java 1a10aa2
exec/java-exec/src/main/java/org/apache/drill/exec/ops/AccountingDataTunnel.java 2bcfdbc
exec/java-exec/src/main/java/org/apache/drill/exec/ops/Consumer.java 9b8ba38
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java cf4e9bb
exec/java-exec/src/main/java/org/apache/drill/exec/ops/StatusHandler.java 79fc0b0
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SingleSenderCreator.java fe6239e
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java b28b7b0
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java e40fe54
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BaseRpcOutcomeListener.java 9b071ad
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicClient.java d551173
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/DrillRpcFutureImpl.java 19d9c30
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/FutureBitCommand.java 6c7bf3e
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ListeningCommand.java e32ca8a
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ReconnectingConnection.java f0787a5
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RemoteConnection.java 2ee9263
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcOutcomeListener.java 7d7c860
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataTunnel.java ed31bed
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java 143d104
exec/java-exec/src/main/java/org/apache/drill/exec/testing/NoOpControlsInjector.java bb13d1f
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java bf62ccb
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 84a38a6
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java d96e6d6
exec/java-exec/src/main/resources/drill-module.conf d98b97a
exec/java-exec/src/test/java/org/apache/drill/exec/ZookeeperHelper.java 7fcf4cb
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestBitRpc.java 3749716
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java d72d498
Diff: https://reviews.apache.org/r/34120/diff/
Testing
-------
Added unittest. Had to disable the unittest because of we leak memory when cancelling the query which causes unittests to fail.
Test suites pass
Thanks,
Venki Korukanti
Re: Review Request 34120: DRILL-2755: (part2) Use and handle
InterruptedException during query processing
Posted by Jacques Nadeau <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34120/#review83504
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ReconnectingConnection.java
<https://reviews.apache.org/r/34120/#comment134508>
shouldn't this have timeout?
- Jacques Nadeau
On May 12, 2015, 9:02 p.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34120/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 9:02 p.m.)
>
>
> Review request for drill and Jacques Nadeau.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Initial patch [1] reports interrupts as failures in logs. This patch addresses the issues to report interrupt to RpcOutcomeListener. Handle the interrupt in RpcOutComeListener depending upon the implementation. Specific details of the handling are here [2]
>
> [1] https://github.com/apache/drill/commit/3a294abcc51148e0e79096af5e6d3c45b7c19a9d
> [2] Goto sheet "RpcOutcomeListener Impl" in https://docs.google.com/spreadsheets/d/1phC5f7E6jn1WN-wXVdUllbIQ2k7K2ZftZzDdhDNLgtg/edit?usp=sharing
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java 1a10aa2
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/AccountingDataTunnel.java 2bcfdbc
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/Consumer.java 9b8ba38
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java cf4e9bb
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/StatusHandler.java 79fc0b0
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SingleSenderCreator.java fe6239e
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java b28b7b0
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java c355070
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java e40fe54
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BaseRpcOutcomeListener.java 9b071ad
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicClient.java d551173
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/DrillRpcFutureImpl.java 19d9c30
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/FutureBitCommand.java 6c7bf3e
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ListeningCommand.java e32ca8a
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ReconnectingConnection.java f0787a5
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RemoteConnection.java 2ee9263
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcOutcomeListener.java 7d7c860
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataTunnel.java ed31bed
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java 143d104
> exec/java-exec/src/main/java/org/apache/drill/exec/testing/NoOpControlsInjector.java bb13d1f
> exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java bf62ccb
> exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 84a38a6
> exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java d96e6d6
> exec/java-exec/src/main/resources/drill-module.conf d98b97a
> exec/java-exec/src/test/java/org/apache/drill/exec/ZookeeperHelper.java 7fcf4cb
> exec/java-exec/src/test/java/org/apache/drill/exec/server/TestBitRpc.java 3749716
> exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java d72d498
>
> Diff: https://reviews.apache.org/r/34120/diff/
>
>
> Testing
> -------
>
> Added unittest. Had to disable the unittest because of we leak memory when cancelling the query which causes unittests to fail.
>
> Test suites pass
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 34120: DRILL-2755: (part2) Use and handle
InterruptedException during query processing
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34120/
-----------------------------------------------------------
(Updated May 12, 2015, 5:06 p.m.)
Review request for drill and Jacques Nadeau.
Changes
-------
Addressed review comment.
Added timeout for Future.get() when waiting for connection.
Repository: drill-git
Description
-------
Initial patch [1] reports interrupts as failures in logs. This patch addresses the issues to report interrupt to RpcOutcomeListener. Handle the interrupt in RpcOutComeListener depending upon the implementation. Specific details of the handling are here [2]
[1] https://github.com/apache/drill/commit/3a294abcc51148e0e79096af5e6d3c45b7c19a9d
[2] Goto sheet "RpcOutcomeListener Impl" in https://docs.google.com/spreadsheets/d/1phC5f7E6jn1WN-wXVdUllbIQ2k7K2ZftZzDdhDNLgtg/edit?usp=sharing
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java 1a10aa2
exec/java-exec/src/main/java/org/apache/drill/exec/ops/AccountingDataTunnel.java 2bcfdbc
exec/java-exec/src/main/java/org/apache/drill/exec/ops/Consumer.java 9b8ba38
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java cf4e9bb
exec/java-exec/src/main/java/org/apache/drill/exec/ops/StatusHandler.java 79fc0b0
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SingleSenderCreator.java fe6239e
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java 611052b
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java c355070
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java e40fe54
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BaseRpcOutcomeListener.java 9b071ad
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicClient.java d551173
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/DrillRpcFutureImpl.java 19d9c30
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/FutureBitCommand.java 6c7bf3e
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ListeningCommand.java e32ca8a
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ReconnectingConnection.java f0787a5
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RemoteConnection.java 2ee9263
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcOutcomeListener.java 7d7c860
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataTunnel.java ed31bed
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java 143d104
exec/java-exec/src/main/java/org/apache/drill/exec/testing/NoOpControlsInjector.java bb13d1f
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java bf62ccb
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 84a38a6
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java d96e6d6
exec/java-exec/src/main/resources/drill-module.conf d98b97a
exec/java-exec/src/test/java/org/apache/drill/exec/ZookeeperHelper.java 7fcf4cb
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestBitRpc.java 3749716
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java d72d498
Diff: https://reviews.apache.org/r/34120/diff/
Testing
-------
Added unittest. Had to disable the unittest because of we leak memory when cancelling the query which causes unittests to fail.
Test suites pass
Thanks,
Venki Korukanti
Re: Review Request 34120: DRILL-2755: (part2) Use and handle
InterruptedException during query processing
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34120/
-----------------------------------------------------------
(Updated May 12, 2015, 2:02 p.m.)
Review request for drill and Jacques Nadeau.
Changes
-------
Enabling the unittest. After applying Chirs's patch for memory leaks (DRILL-3033), I don't see any more leaks when query is cancelled.
Repository: drill-git
Description
-------
Initial patch [1] reports interrupts as failures in logs. This patch addresses the issues to report interrupt to RpcOutcomeListener. Handle the interrupt in RpcOutComeListener depending upon the implementation. Specific details of the handling are here [2]
[1] https://github.com/apache/drill/commit/3a294abcc51148e0e79096af5e6d3c45b7c19a9d
[2] Goto sheet "RpcOutcomeListener Impl" in https://docs.google.com/spreadsheets/d/1phC5f7E6jn1WN-wXVdUllbIQ2k7K2ZftZzDdhDNLgtg/edit?usp=sharing
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java 1a10aa2
exec/java-exec/src/main/java/org/apache/drill/exec/ops/AccountingDataTunnel.java 2bcfdbc
exec/java-exec/src/main/java/org/apache/drill/exec/ops/Consumer.java 9b8ba38
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java cf4e9bb
exec/java-exec/src/main/java/org/apache/drill/exec/ops/StatusHandler.java 79fc0b0
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SingleSenderCreator.java fe6239e
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java b28b7b0
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java c355070
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java e40fe54
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BaseRpcOutcomeListener.java 9b071ad
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BasicClient.java d551173
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/DrillRpcFutureImpl.java 19d9c30
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/FutureBitCommand.java 6c7bf3e
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ListeningCommand.java e32ca8a
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ReconnectingConnection.java f0787a5
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RemoteConnection.java 2ee9263
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcOutcomeListener.java 7d7c860
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataTunnel.java ed31bed
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java 143d104
exec/java-exec/src/main/java/org/apache/drill/exec/testing/NoOpControlsInjector.java bb13d1f
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java bf62ccb
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java 84a38a6
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java d96e6d6
exec/java-exec/src/main/resources/drill-module.conf d98b97a
exec/java-exec/src/test/java/org/apache/drill/exec/ZookeeperHelper.java 7fcf4cb
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestBitRpc.java 3749716
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java d72d498
Diff: https://reviews.apache.org/r/34120/diff/
Testing
-------
Added unittest. Had to disable the unittest because of we leak memory when cancelling the query which causes unittests to fail.
Test suites pass
Thanks,
Venki Korukanti