You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jason Bausewein <ja...@tier3.com> on 2012/06/30 01:59:49 UTC
Review Request: NullPointerException in CreateVlanIpRangeCmd when creating
guest IP ranges with deployDataCenter.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5678/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
When creating a basic network configuration with tools/marvin/marvin/deployDataCenter.py, the command to create the guest ip ranges will fail.
2012-06-29 14:08:03,831 ERROR [cloud.api.ApiDispatcher] (catalina-exec-7:null) Exception while executing CreateVlanIpRangeCmd:
java.lang.NullPointerException
at com.cloud.configuration.ConfigurationManagerImpl.createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2144)
at com.cloud.utils.component.ComponentLocator$InterceptorDispatcher.intercept(ComponentLocator.java:1189)
at com.cloud.api.commands.CreateVlanIpRangeCmd.execute(CreateVlanIpRangeCmd.java:164)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:134)
at com.cloud.api.ApiServer.queueCommand(ApiServer.java:538)
at com.cloud.api.ApiServer.handleRequest(ApiServer.java:418)
at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:300)
at com.cloud.api.ApiServlet.doGet(ApiServlet.java:59)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
at org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:886)
at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:721)
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2256)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:679)
When using basic networking and not specifying the network, the code needs to fetch the network as well.
Diffs
-----
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 078916e
Diff: https://reviews.apache.org/r/5678/diff/
Testing
-------
Guest IP ranges are created correctly after this change.
Thanks,
Jason Bausewein
Re: Review Request: NullPointerException in CreateVlanIpRangeCmd when
creating guest IP ranges with deployDataCenter.py
Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5678/#review8816
-----------------------------------------------------------
Ship it!
Ship It!
- Sheng Yang
On June 29, 2012, 11:59 p.m., Jason Bausewein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5678/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 11:59 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> When creating a basic network configuration with tools/marvin/marvin/deployDataCenter.py, the command to create the guest ip ranges will fail.
>
> 2012-06-29 14:08:03,831 ERROR [cloud.api.ApiDispatcher] (catalina-exec-7:null) Exception while executing CreateVlanIpRangeCmd:
> java.lang.NullPointerException
> at com.cloud.configuration.ConfigurationManagerImpl.createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2144)
> at com.cloud.utils.component.ComponentLocator$InterceptorDispatcher.intercept(ComponentLocator.java:1189)
> at com.cloud.api.commands.CreateVlanIpRangeCmd.execute(CreateVlanIpRangeCmd.java:164)
> at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:134)
> at com.cloud.api.ApiServer.queueCommand(ApiServer.java:538)
> at com.cloud.api.ApiServer.handleRequest(ApiServer.java:418)
> at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:300)
> at com.cloud.api.ApiServlet.doGet(ApiServlet.java:59)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
> at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
> at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
> at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
> at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
> at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
> at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
> at org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:886)
> at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:721)
> at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2256)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
>
> When using basic networking and not specifying the network, the code needs to fetch the network as well.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 078916e
>
> Diff: https://reviews.apache.org/r/5678/diff/
>
>
> Testing
> -------
>
> Guest IP ranges are created correctly after this change.
>
>
> Thanks,
>
> Jason Bausewein
>
>
Re: Review Request: NullPointerException in CreateVlanIpRangeCmd when
creating guest IP ranges with deployDataCenter.py
Posted by Jason Bausewein <ja...@tier3.com>.
> On June 30, 2012, 12:05 a.m., David Nalley wrote:
> > Is there a bug filed for this?
> >
> > --David
http://bugs.cloudstack.org/browse/CS-15274
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5678/#review8770
-----------------------------------------------------------
On June 29, 2012, 11:59 p.m., Jason Bausewein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5678/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 11:59 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> When creating a basic network configuration with tools/marvin/marvin/deployDataCenter.py, the command to create the guest ip ranges will fail.
>
> 2012-06-29 14:08:03,831 ERROR [cloud.api.ApiDispatcher] (catalina-exec-7:null) Exception while executing CreateVlanIpRangeCmd:
> java.lang.NullPointerException
> at com.cloud.configuration.ConfigurationManagerImpl.createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2144)
> at com.cloud.utils.component.ComponentLocator$InterceptorDispatcher.intercept(ComponentLocator.java:1189)
> at com.cloud.api.commands.CreateVlanIpRangeCmd.execute(CreateVlanIpRangeCmd.java:164)
> at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:134)
> at com.cloud.api.ApiServer.queueCommand(ApiServer.java:538)
> at com.cloud.api.ApiServer.handleRequest(ApiServer.java:418)
> at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:300)
> at com.cloud.api.ApiServlet.doGet(ApiServlet.java:59)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
> at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
> at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
> at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
> at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
> at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
> at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
> at org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:886)
> at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:721)
> at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2256)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
>
> When using basic networking and not specifying the network, the code needs to fetch the network as well.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 078916e
>
> Diff: https://reviews.apache.org/r/5678/diff/
>
>
> Testing
> -------
>
> Guest IP ranges are created correctly after this change.
>
>
> Thanks,
>
> Jason Bausewein
>
>
Re: Review Request: NullPointerException in CreateVlanIpRangeCmd when
creating guest IP ranges with deployDataCenter.py
Posted by David Nalley <da...@gnsa.us>.
On Fri, Jun 29, 2012 at 8:26 PM, Jason Bausewein
<ja...@tier3.com> wrote:
> I just searched for bugs and found this one.
>
> NullPointerException seen when using CreateVlanIpRangeCmd() with zoneid
>
> http://bugs.cloudstack.org/browse/CS-15274
>
> It looks like the patch will fix this issue. I'm new to bug fixing, what should I do next?
>
> Jason
Basically just hang out til someone reviews the patch in a few days.
Thanks for the patch!
--David
RE: Review Request: NullPointerException in CreateVlanIpRangeCmd
when creating guest IP ranges with deployDataCenter.py
Posted by Jason Bausewein <ja...@tier3.com>.
I just searched for bugs and found this one.
NullPointerException seen when using CreateVlanIpRangeCmd() with zoneid
http://bugs.cloudstack.org/browse/CS-15274
It looks like the patch will fix this issue. I'm new to bug fixing, what should I do next?
Jason
-----Original Message-----
From: David Nalley [mailto:david@gnsa.us]
Sent: Friday, June 29, 2012 5:16 PM
To: cloudstack-dev@incubator.apache.org
Subject: Re: Review Request: NullPointerException in CreateVlanIpRangeCmd when creating guest IP ranges with deployDataCenter.py
On Fri, Jun 29, 2012 at 8:10 PM, Jason Bausewein <ja...@tier3.com> wrote:
> Not Yet, should I file a bug first before submitting patch request?
I don't know that it's a must - but it's at least a good practice, that way if someone else runs into the problem they can search the bugtracker and see that's it's fixed (or was fixed and has regressed)
--David
Re: Review Request: NullPointerException in CreateVlanIpRangeCmd when
creating guest IP ranges with deployDataCenter.py
Posted by David Nalley <da...@gnsa.us>.
On Fri, Jun 29, 2012 at 8:10 PM, Jason Bausewein
<ja...@tier3.com> wrote:
> Not Yet, should I file a bug first before submitting patch request?
I don't know that it's a must - but it's at least a good practice,
that way if someone else runs into the problem they can search the
bugtracker and see that's it's fixed (or was fixed and has regressed)
--David
RE: Review Request: NullPointerException in CreateVlanIpRangeCmd
when creating guest IP ranges with deployDataCenter.py
Posted by Jason Bausewein <ja...@tier3.com>.
Not Yet, should I file a bug first before submitting patch request?
-----Original Message-----
From: David Nalley [mailto:noreply@reviews.apache.org] On Behalf Of David Nalley
Sent: Friday, June 29, 2012 5:05 PM
To: cloudstack; David Nalley; Jason Bausewein
Subject: Re: Review Request: NullPointerException in CreateVlanIpRangeCmd when creating guest IP ranges with deployDataCenter.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5678/#review8770
-----------------------------------------------------------
Is there a bug filed for this?
--David
- David Nalley
On June 29, 2012, 11:59 p.m., Jason Bausewein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5678/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 11:59 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> When creating a basic network configuration with tools/marvin/marvin/deployDataCenter.py, the command to create the guest ip ranges will fail.
>
> 2012-06-29 14:08:03,831 ERROR [cloud.api.ApiDispatcher] (catalina-exec-7:null) Exception while executing CreateVlanIpRangeCmd:
> java.lang.NullPointerException
> at com.cloud.configuration.ConfigurationManagerImpl.createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2144)
> at com.cloud.utils.component.ComponentLocator$InterceptorDispatcher.intercept(ComponentLocator.java:1189)
> at com.cloud.api.commands.CreateVlanIpRangeCmd.execute(CreateVlanIpRangeCmd.java:164)
> at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:134)
> at com.cloud.api.ApiServer.queueCommand(ApiServer.java:538)
> at com.cloud.api.ApiServer.handleRequest(ApiServer.java:418)
> at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:300)
> at com.cloud.api.ApiServlet.doGet(ApiServlet.java:59)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
> at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
> at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
> at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
> at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
> at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
> at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
> at org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:886)
> at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:721)
> at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2256)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
>
> When using basic networking and not specifying the network, the code needs to fetch the network as well.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 078916e
>
> Diff: https://reviews.apache.org/r/5678/diff/
>
>
> Testing
> -------
>
> Guest IP ranges are created correctly after this change.
>
>
> Thanks,
>
> Jason Bausewein
>
>
Re: Review Request: NullPointerException in CreateVlanIpRangeCmd when
creating guest IP ranges with deployDataCenter.py
Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5678/#review8770
-----------------------------------------------------------
Is there a bug filed for this?
--David
- David Nalley
On June 29, 2012, 11:59 p.m., Jason Bausewein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5678/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 11:59 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> When creating a basic network configuration with tools/marvin/marvin/deployDataCenter.py, the command to create the guest ip ranges will fail.
>
> 2012-06-29 14:08:03,831 ERROR [cloud.api.ApiDispatcher] (catalina-exec-7:null) Exception while executing CreateVlanIpRangeCmd:
> java.lang.NullPointerException
> at com.cloud.configuration.ConfigurationManagerImpl.createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2144)
> at com.cloud.utils.component.ComponentLocator$InterceptorDispatcher.intercept(ComponentLocator.java:1189)
> at com.cloud.api.commands.CreateVlanIpRangeCmd.execute(CreateVlanIpRangeCmd.java:164)
> at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:134)
> at com.cloud.api.ApiServer.queueCommand(ApiServer.java:538)
> at com.cloud.api.ApiServer.handleRequest(ApiServer.java:418)
> at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:300)
> at com.cloud.api.ApiServlet.doGet(ApiServlet.java:59)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
> at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
> at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
> at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
> at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:555)
> at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
> at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
> at org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:886)
> at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:721)
> at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2256)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
>
> When using basic networking and not specifying the network, the code needs to fetch the network as well.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 078916e
>
> Diff: https://reviews.apache.org/r/5678/diff/
>
>
> Testing
> -------
>
> Guest IP ranges are created correctly after this change.
>
>
> Thanks,
>
> Jason Bausewein
>
>