You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xinyiZzz (via GitHub)" <gi...@apache.org> on 2023/01/29 10:04:15 UTC
[GitHub] [doris] xinyiZzz opened a new pull request, #16208: [improvement](metrics) Metrics add all rowset nums and segment nums
xinyiZzz opened a new pull request, #16208:
URL: https://github.com/apache/doris/pull/16208
# Proposed changes
Issue Number: close #xxx
## Problem summary
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16208: [improvement](metrics) Metrics add all rowset nums and segment nums
Posted by github-actions.
github-actions[bot] commented on PR #16208:
URL: https://github.com/apache/doris/pull/16208#issuecomment-1407644774
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #16208: [improvement](metrics) Metrics add all rowset nums and segment nums
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #16208:
URL: https://github.com/apache/doris/pull/16208#discussion_r1089931406
##########
be/src/olap/tablet.h:
##########
@@ -550,6 +551,14 @@ inline Version Tablet::max_version() const {
return _tablet_meta->max_version();
}
+inline uint64_t Tablet::segment_count() const {
+ uint64_t segment_nums = 0;
Review Comment:
need read lock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16208: [improvement](metrics) Metrics add all rowset nums and segment nums
Posted by github-actions.
github-actions[bot] commented on PR #16208:
URL: https://github.com/apache/doris/pull/16208#issuecomment-1407619426
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on a diff in pull request #16208: [improvement](metrics) Metrics add all rowset nums and segment nums
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #16208:
URL: https://github.com/apache/doris/pull/16208#discussion_r1089940330
##########
be/src/olap/tablet.h:
##########
@@ -550,6 +551,14 @@ inline Version Tablet::max_version() const {
return _tablet_meta->max_version();
}
+inline uint64_t Tablet::segment_count() const {
+ uint64_t segment_nums = 0;
Review Comment:
fix~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16208: [improvement](metrics) Metrics add all rowset nums and segment nums
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #16208:
URL: https://github.com/apache/doris/pull/16208#issuecomment-1407678718
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.09 seconds
load time: 522 seconds
storage size: 17122531884 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230129142921_clickbench_pr_86529.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #16208: [improvement](metrics) Metrics add all rowset nums and segment nums
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #16208:
URL: https://github.com/apache/doris/pull/16208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org