[GitHub] [pulsar] poorbarcode commented on a diff in pull request #15181: [cleanup] [broker] when serverCnx disabled auto read use same implements

[GitBox <gi...@apache.org>]

poorbarcode commented on code in PR #15181:
URL: https://github.com/apache/pulsar/pull/15181#discussion_r853411748


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -2645,8 +2645,7 @@ public void startSendOperation(Producer producer, int msgSize, int numMessages)
         if (++pendingSendRequest == maxPendingSendRequests || isPublishRateExceeded) {
             // When the quota of pending send requests is reached, stop reading from socket to cause backpressure on
             // client connection, possibly shared between multiple producers
-            ctx.channel().config().setAutoRead(false);
-            recordRateLimitMetrics(producers);

Review Comment:
   > is this just an inferred conclusion ?
   
   yes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org