You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "cadonna (via GitHub)" <gi...@apache.org> on 2024/05/06 09:46:57 UTC
[PR] KAFKA-10199: Revoke tasks from state updater with new remove [kafka]
cadonna opened a new pull request, #15871:
URL: https://github.com/apache/kafka/pull/15871
Uses the new remove operation of the state updater that returns
a future to remove revoked tasks from the state udpater.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-10199: Revoke tasks from state updater with new remove [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on code in PR #15871:
URL: https://github.com/apache/kafka/pull/15871#discussion_r1592261128
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -623,6 +623,21 @@ private void addToTasksToClose(final Map<TaskId, CompletableFuture<StateUpdater.
});
}
+ private void iterateAndActOnRemovedTask(final Map<TaskId, CompletableFuture<StateUpdater.RemovedTaskResult>> futures,
Review Comment:
Are we going to reuse this method? Otherwise, I find this a bit too abstract, and I'd just inline it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-10199: Revoke tasks from state updater with new remove [kafka]
Posted by "rishiraj88 (via GitHub)" <gi...@apache.org>.
rishiraj88 commented on code in PR #15871:
URL: https://github.com/apache/kafka/pull/15871#discussion_r1593553420
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -623,6 +623,21 @@ private void addToTasksToClose(final Map<TaskId, CompletableFuture<StateUpdater.
});
}
+ private void iterateAndActOnRemovedTask(final Map<TaskId, CompletableFuture<StateUpdater.RemovedTaskResult>> futures,
Review Comment:
OK then. Let's continue to have it as a method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-10199: Revoke tasks from state updater with new remove [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna commented on code in PR #15871:
URL: https://github.com/apache/kafka/pull/15871#discussion_r1592297149
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -623,6 +623,21 @@ private void addToTasksToClose(final Map<TaskId, CompletableFuture<StateUpdater.
});
}
+ private void iterateAndActOnRemovedTask(final Map<TaskId, CompletableFuture<StateUpdater.RemovedTaskResult>> futures,
Review Comment:
Yes, we are going to re-use it. Stay tuned!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-10199: Revoke tasks from state updater with new remove [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna merged PR #15871:
URL: https://github.com/apache/kafka/pull/15871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org