You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dlab.apache.org by ad...@apache.org on 2019/09/12 13:20:06 UTC

[incubator-dlab] branch DLAB-1037 created (now df48bb4)

This is an automated email from the ASF dual-hosted git repository.

adamsd pushed a change to branch DLAB-1037
in repository https://gitbox.apache.org/repos/asf/incubator-dlab.git.


      at df48bb4  [DLAB-1037]: Notebook creation fails in case of allocating the same CIDR to different subnets

This branch includes the following new commits:

     new df48bb4  [DLAB-1037]: Notebook creation fails in case of allocating the same CIDR to different subnets

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@dlab.apache.org
For additional commands, e-mail: commits-help@dlab.apache.org


[incubator-dlab] 01/01: [DLAB-1037]: Notebook creation fails in case of allocating the same CIDR to different subnets

Posted by ad...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

adamsd pushed a commit to branch DLAB-1037
in repository https://gitbox.apache.org/repos/asf/incubator-dlab.git

commit df48bb423150777c51dee2f6ea25997eae83e7bd
Author: AdamsDisturber <ad...@gmail.com>
AuthorDate: Thu Sep 12 16:19:56 2019 +0300

    [DLAB-1037]: Notebook creation fails in case of allocating the same CIDR to different subnets
---
 .../src/general/scripts/aws/common_prepare_notebook.py                 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/infrastructure-provisioning/src/general/scripts/aws/common_prepare_notebook.py b/infrastructure-provisioning/src/general/scripts/aws/common_prepare_notebook.py
index 6d3de38..64d13e8 100644
--- a/infrastructure-provisioning/src/general/scripts/aws/common_prepare_notebook.py
+++ b/infrastructure-provisioning/src/general/scripts/aws/common_prepare_notebook.py
@@ -118,7 +118,8 @@ if __name__ == "__main__":
         params = "--node_name {} --ami_id {} --instance_type {} --key_name {} --security_group_ids {} --subnet_id {} --iam_profile {} --infra_tag_name {} --infra_tag_value {} --instance_class {} --instance_disk_size {} --primary_disk_size {}" \
             .format(notebook_config['instance_name'], notebook_config['ami_id'], notebook_config['instance_type'],
                     notebook_config['key_name'], get_security_group_by_name(notebook_config['security_group_name']),
-                    get_subnet_by_cidr(notebook_config['subnet_cidr']), notebook_config['role_profile_name'],
+                    get_subnet_by_cidr(notebook_config['subnet_cidr'], os.environ['aws_notebook_vpc_id']),
+                    notebook_config['role_profile_name'],
                     notebook_config['tag_name'], notebook_config['instance_name'], instance_class,
                     os.environ['notebook_disk_size'], notebook_config['primary_disk_size'])
         try:


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@dlab.apache.org
For additional commands, e-mail: commits-help@dlab.apache.org