You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/12 16:25:46 UTC
[GitHub] [superset] betodealmeida opened a new pull request #13601: WIP
betodealmeida opened a new pull request #13601:
URL: https://github.com/apache/superset/pull/13601
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
When connecting to a database fails, do some diagnostics to present better messages to the user.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Resposne from invalid hostname (`postgres://username:password@host:12345/db`):
```json
{
"errors": [
{
"message": "Unable to resolve hostname \"host\".",
"error_type": "TEST_CONNECTION_INVALID_HOSTNAME_ERROR",
"level": "error",
"extra": {
"hostname": "host",
"issue_codes": [
{
"code": 1007,
"message": "Issue 1007 - The hostname provided can't be resolved."
}
]
}
}
]
}
```
Response from valid hostname, with host up but port closed (`postgres://username:password@localhost:12345/db`):
```json
{
"errors": [
{
"message": "The host localhost is up, but the port 12345 is closed.",
"error_type": "TEST_CONNECTION_PORT_CLOSED_ERROR",
"level": "error",
"extra": {
"hostname": "localhost",
"port": 12345,
"issue_codes": [
{
"code": 1008,
"message": "Issue 1008 - The port is closed."
}
]
}
}
]
}
```
Response from valid hostname, but host is down (`postgres://username:password@pub.dealmeida.net:12345/db`):
```json
{
"errors": [
{
"message": "The host pub.dealmeida.net might be down, ond can't be reached on port 12345.",
"error_type": "TEST_CONNECTION_HOST_DOWN_ERROR",
"level": "error",
"extra": {
"hostname": "pub.dealmeida.net",
"port": 12345,
"issue_codes": [
{
"code": 1009,
"message": "Issue 1009 - The host might be down, and can't be reached on the provided port."
}
]
}
}
]
}
```
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (e73abee) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `1.77%`.
> The diff coverage is `64.42%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 75.76% -1.78%
==========================================
Files 904 919 +15
Lines 45986 46711 +725
Branches 5552 5723 +171
==========================================
- Hits 35657 35390 -267
- Misses 10195 11165 +970
- Partials 134 156 +22
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.94% <17.84%> (-4.26%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.21%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.93%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <84.93%> (-0.32%)` | :arrow_down: |
| sqlite | `80.17% <82.21%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `67.74% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `54.16% <0.00%> (-11.06%)` | :arrow_down: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| ... and [201 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...8cc8f70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (d7c0abc) into [master](https://codecov.io/gh/apache/superset/commit/036fc3944d72347dc553d77cb61f179ad7ec3ac3?el=desc) (036fc39) will **decrease** coverage by `6.07%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head d7c0abc differs from pull request most recent head 398e255. Consider uploading reports for the commit 398e255 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.10% 71.02% -6.08%
==========================================
Files 921 839 -82
Lines 46745 41867 -4878
Branches 5733 4334 -1399
==========================================
- Hits 36041 29735 -6306
- Misses 10569 12132 +1563
+ Partials 135 0 -135
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.60% <100.00%> (+<0.01%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.59% <76.66%> (?)` | |
| python | `80.64% <76.66%> (+0.08%)` | :arrow_up: |
| sqlite | `80.18% <60.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `58.06% <58.06%> (ø)` | |
| [superset/utils/log.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.38% <66.66%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `100.00% <100.00%> (+40.00%)` | :arrow_up: |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.18% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `98.41% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [514 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [036fc39...398e255](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (11d7b70) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.82%`.
> The diff coverage is `77.04%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 76.71% -0.83%
==========================================
Files 904 919 +15
Lines 45986 46711 +725
Branches 5552 5723 +171
==========================================
+ Hits 35657 35834 +177
- Misses 10195 10735 +540
- Partials 134 142 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.47% <ø> (-3.74%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.05% <ø> (-0.33%)` | :arrow_down: |
| mysql | `80.54% <77.04%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <77.04%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <77.04%> (-0.32%)` | :arrow_down: |
| sqlite | `80.17% <60.65%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `59.37% <59.37%> (ø)` | |
| [superset/utils/log.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.38% <66.66%> (-0.65%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.18% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `98.43% <100.00%> (+0.52%)` | :arrow_up: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| ... and [106 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...11d7b70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (e73abee) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.24%`.
> The diff coverage is `65.20%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.29% -0.25%
==========================================
Files 904 919 +15
Lines 45986 46713 +727
Branches 5552 5723 +171
==========================================
+ Hits 35657 36108 +451
- Misses 10195 10469 +274
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `80.24% <84.93%> (+0.11%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.21%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.93%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.98% <85.11%> (-0.02%)` | :arrow_down: |
| sqlite | `80.17% <82.21%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [111 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...8cc8f70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (e73abee) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `5.03%`.
> The diff coverage is `63.93%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 72.50% -5.04%
==========================================
Files 904 919 +15
Lines 45986 46652 +666
Branches 5552 5723 +171
==========================================
- Hits 35657 33826 -1831
- Misses 10195 12610 +2415
- Partials 134 216 +82
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.21%> (+0.08%)` | :arrow_up: |
| postgres | `80.58% <84.93%> (+0.08%)` | :arrow_up: |
| presto | `?` | |
| python | `80.66% <84.93%> (-0.34%)` | :arrow_down: |
| sqlite | `80.17% <82.21%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `70.00% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `25.00% <0.00%> (-2.59%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `56.52% <0.00%> (-8.70%)` | :arrow_down: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `64.89% <0.00%> (-2.13%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `54.61% <ø> (-5.39%)` | :arrow_down: |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| ... and [336 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...8cc8f70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (5460b51) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.24%`.
> The diff coverage is `65.16%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.29% -0.25%
==========================================
Files 904 919 +15
Lines 45986 46712 +726
Branches 5552 5723 +171
==========================================
+ Hits 35657 36106 +449
- Misses 10195 10470 +275
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `80.24% <84.90%> (+0.11%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.18%> (+0.08%)` | :arrow_up: |
| postgres | `80.59% <84.90%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.97% <85.09%> (-0.03%)` | :arrow_down: |
| sqlite | `80.17% <82.18%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [112 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...0bd8f38](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (5460b51) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `1.35%`.
> The diff coverage is `64.38%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 76.17% -1.36%
==========================================
Files 904 919 +15
Lines 45986 46711 +725
Branches 5552 5723 +171
==========================================
- Hits 35657 35584 -73
- Misses 10195 10971 +776
- Partials 134 156 +22
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.03% <17.73%> (-6.18%)` | :arrow_down: |
| hive | `80.24% <84.90%> (+0.11%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.18%> (+0.08%)` | :arrow_up: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.89% <85.09%> (-0.11%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `67.74% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `54.16% <0.00%> (-11.06%)` | :arrow_down: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| ... and [180 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...0bd8f38](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (f061870) into [master](https://codecov.io/gh/apache/superset/commit/036fc3944d72347dc553d77cb61f179ad7ec3ac3?el=desc) (036fc39) will **decrease** coverage by `3.97%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head f061870 differs from pull request most recent head 398e255. Consider uploading reports for the commit 398e255 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.10% 73.12% -3.98%
==========================================
Files 921 611 -310
Lines 46745 21722 -25023
Branches 5733 5644 -89
==========================================
- Hits 36041 15884 -20157
+ Misses 10569 5703 -4866
Partials 135 135
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.61% <100.00%> (+0.01%)` | :arrow_up: |
| javascript | `63.14% <0.00%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `66.66% <100.00%> (+6.66%)` | :arrow_up: |
| [superset/views/log/api.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | | |
| [superset/cachekeys/api.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2FjaGVrZXlzL2FwaS5weQ==) | | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | | |
| [superset/connectors/base/views.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | | |
| [superset/cachekeys/schemas.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2FjaGVrZXlzL3NjaGVtYXMucHk=) | | |
| [superset/reports/filters.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9maWx0ZXJzLnB5) | | |
| [superset/examples/css\_templates.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY3NzX3RlbXBsYXRlcy5weQ==) | | |
| ... and [298 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [036fc39...398e255](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (685fa91) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.24%`.
> The diff coverage is `65.24%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.29% -0.25%
==========================================
Files 904 919 +15
Lines 45986 46713 +727
Branches 5552 5723 +171
==========================================
+ Hits 35657 36108 +451
- Misses 10195 10469 +274
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `80.22% <84.78%> (+0.09%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.23%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.96%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.98% <85.14%> (-0.02%)` | :arrow_down: |
| sqlite | `80.17% <82.24%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [111 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...8cc8f70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (d7c0abc) into [master](https://codecov.io/gh/apache/superset/commit/036fc3944d72347dc553d77cb61f179ad7ec3ac3?el=desc) (036fc39) will **decrease** coverage by `6.12%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head d7c0abc differs from pull request most recent head 398e255. Consider uploading reports for the commit 398e255 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.10% 70.97% -6.13%
==========================================
Files 921 839 -82
Lines 46745 41839 -4906
Branches 5733 4334 -1399
==========================================
- Hits 36041 29697 -6344
- Misses 10569 12142 +1573
+ Partials 135 0 -135
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.60% <100.00%> (+<0.01%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.58% <76.66%> (?)` | |
| python | `80.58% <76.66%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `58.06% <58.06%> (ø)` | |
| [superset/utils/log.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.38% <66.66%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `100.00% <100.00%> (+40.00%)` | :arrow_up: |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.18% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `98.41% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [504 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [036fc39...398e255](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (685fa91) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **increase** coverage by `3.14%`.
> The diff coverage is `84.96%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
+ Coverage 77.53% 80.68% +3.14%
==========================================
Files 904 311 -593
Lines 45986 25073 -20913
Branches 5552 0 -5552
==========================================
- Hits 35657 20230 -15427
+ Misses 10195 4843 -5352
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.54% <84.23%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.96%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <84.96%> (-0.32%)` | :arrow_down: |
| sqlite | `80.17% <82.24%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.44% <ø> (ø)` | |
| [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
| [superset/utils/data.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0YS5weQ==) | `27.94% <27.94%> (ø)` | |
| [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `33.33% <33.33%> (ø)` | |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `59.37% <59.37%> (ø)` | |
| [superset/utils/log.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.38% <66.66%> (-0.65%)` | :arrow_down: |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <92.30%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <92.30%> (-6.67%)` | :arrow_down: |
| ... and [596 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...8cc8f70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (11d7b70) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `5.03%`.
> The diff coverage is `77.04%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 72.50% -5.04%
==========================================
Files 904 919 +15
Lines 45986 46678 +692
Branches 5552 5723 +171
==========================================
- Hits 35657 33842 -1815
- Misses 10195 12620 +2425
- Partials 134 216 +82
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `63.05% <ø> (-0.33%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `80.60% <77.04%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.64% <77.04%> (-0.37%)` | :arrow_down: |
| sqlite | `80.17% <60.65%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `59.37% <59.37%> (ø)` | |
| [superset/utils/log.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.38% <66.66%> (-0.65%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.18% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `98.43% <100.00%> (+0.52%)` | :arrow_up: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [276 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...11d7b70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (5460b51) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.24%`.
> The diff coverage is `65.16%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.29% -0.25%
==========================================
Files 904 919 +15
Lines 45986 46712 +726
Branches 5552 5723 +171
==========================================
+ Hits 35657 36107 +450
- Misses 10195 10469 +274
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `80.24% <84.90%> (+0.11%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.18%> (+0.08%)` | :arrow_up: |
| postgres | `80.59% <84.90%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.98% <85.09%> (-0.02%)` | :arrow_down: |
| sqlite | `80.17% <82.18%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [111 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...67260de](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: WIP
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (2a8e6fb) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.32%`.
> The diff coverage is `59.24%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.21% -0.33%
==========================================
Files 904 911 +7
Lines 45986 46416 +430
Branches 5552 5692 +140
==========================================
+ Hits 35657 35841 +184
- Misses 10195 10439 +244
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <23.56%> (-0.48%)` | :arrow_down: |
| hive | `80.04% <75.00%> (-0.09%)` | :arrow_down: |
| javascript | `63.06% <29.03%> (-0.32%)` | :arrow_down: |
| mysql | `80.34% <73.41%> (-0.12%)` | :arrow_down: |
| postgres | `80.38% <74.68%> (-0.12%)` | :arrow_down: |
| presto | `?` | |
| python | `80.78% <75.00%> (-0.22%)` | :arrow_down: |
| sqlite | `79.96% <69.30%> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `36.84% <0.00%> (-2.05%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (ø)` | |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [60 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...e6595a8](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13601: WIP
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (2a8e6fb) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `1.42%`.
> The diff coverage is `55.66%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 76.11% -1.43%
==========================================
Files 904 911 +7
Lines 45986 46388 +402
Branches 5552 5692 +140
==========================================
- Hits 35657 35306 -351
- Misses 10195 10937 +742
- Partials 134 145 +11
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.50% <23.56%> (-3.71%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.06% <29.03%> (-0.32%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `79.96% <69.30%> (-1.05%)` | :arrow_down: |
| sqlite | `79.96% <69.30%> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `36.84% <0.00%> (-2.05%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (ø)` | |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [135 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...e6595a8](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (11d7b70) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.74%`.
> The diff coverage is `77.04%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 76.78% -0.75%
==========================================
Files 904 919 +15
Lines 45986 46711 +725
Branches 5552 5723 +171
==========================================
+ Hits 35657 35869 +212
- Misses 10195 10700 +505
- Partials 134 142 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.47% <ø> (-3.74%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.05% <ø> (-0.33%)` | :arrow_down: |
| mysql | `80.54% <77.04%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <77.04%> (+0.10%)` | :arrow_up: |
| presto | `80.27% <77.04%> (+0.10%)` | :arrow_up: |
| python | `80.82% <77.04%> (-0.18%)` | :arrow_down: |
| sqlite | `80.17% <60.65%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `59.37% <59.37%> (ø)` | |
| [superset/utils/log.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.38% <66.66%> (-0.65%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.18% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `98.43% <100.00%> (+0.52%)` | :arrow_up: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [...teFilterControl/components/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0RhdGVGdW5jdGlvblRvb2x0aXAudHN4) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| ... and [105 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...5ba8639](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (e73abee) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.40%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.13% -0.41%
==========================================
Files 904 919 +15
Lines 45986 46713 +727
Branches 5552 5723 +171
==========================================
+ Hits 35657 36033 +376
- Misses 10195 10544 +349
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.21%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.93%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <84.93%> (-0.32%)` | :arrow_down: |
| sqlite | `80.17% <82.21%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [115 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...8cc8f70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (685fa91) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `1.44%`.
> The diff coverage is `64.46%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 76.08% -1.45%
==========================================
Files 904 919 +15
Lines 45986 46712 +726
Branches 5552 5723 +171
==========================================
- Hits 35657 35543 -114
- Misses 10195 11011 +816
- Partials 134 158 +24
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.68% <18.08%> (-6.53%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.23%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.96%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <84.96%> (-0.32%)` | :arrow_down: |
| sqlite | `80.17% <82.24%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `67.74% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `54.16% <0.00%> (-11.06%)` | :arrow_down: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| ... and [178 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...8cc8f70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (685fa91) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `5.01%`.
> The diff coverage is `63.97%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 72.52% -5.02%
==========================================
Files 904 919 +15
Lines 45986 46680 +694
Branches 5552 5723 +171
==========================================
- Hits 35657 33853 -1804
- Misses 10195 12611 +2416
- Partials 134 216 +82
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.23%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.96%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <84.96%> (-0.32%)` | :arrow_down: |
| sqlite | `80.17% <82.24%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `70.00% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `25.00% <0.00%> (-2.59%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `56.52% <0.00%> (-8.70%)` | :arrow_down: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `64.89% <0.00%> (-2.13%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `54.61% <ø> (-5.39%)` | :arrow_down: |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| ... and [328 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...8cc8f70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (e73abee) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.18%`.
> The diff coverage is `65.20%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.35% -0.19%
==========================================
Files 904 919 +15
Lines 45986 46713 +727
Branches 5552 5723 +171
==========================================
+ Hits 35657 36135 +478
- Misses 10195 10442 +247
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `80.24% <84.93%> (+0.11%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.21%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.93%> (+0.10%)` | :arrow_up: |
| presto | `80.27% <84.93%> (+0.10%)` | :arrow_up: |
| python | `81.09% <85.11%> (+0.09%)` | :arrow_up: |
| sqlite | `80.17% <82.21%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [111 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...0bd8f38](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (d7c0abc) into [master](https://codecov.io/gh/apache/superset/commit/036fc3944d72347dc553d77cb61f179ad7ec3ac3?el=desc) (036fc39) will **decrease** coverage by `5.87%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head d7c0abc differs from pull request most recent head 398e255. Consider uploading reports for the commit 398e255 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.10% 71.22% -5.88%
==========================================
Files 921 839 -82
Lines 46745 41867 -4878
Branches 5733 4334 -1399
==========================================
- Hits 36041 29821 -6220
- Misses 10569 12046 +1477
+ Partials 135 0 -135
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.60% <100.00%> (+<0.01%)` | :arrow_up: |
| hive | `80.22% <76.66%> (?)` | |
| javascript | `?` | |
| mysql | `80.54% <76.66%> (-0.02%)` | :arrow_down: |
| postgres | `80.59% <76.66%> (?)` | |
| python | `80.98% <76.66%> (+0.42%)` | :arrow_up: |
| sqlite | `80.18% <60.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `58.06% <58.06%> (ø)` | |
| [superset/utils/log.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.38% <66.66%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `100.00% <100.00%> (+40.00%)` | :arrow_up: |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.18% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `98.41% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [515 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [036fc39...398e255](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: WIP
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (2a8e6fb) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.26%`.
> The diff coverage is `59.24%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.27% -0.27%
==========================================
Files 904 911 +7
Lines 45986 46416 +430
Branches 5552 5692 +140
==========================================
+ Hits 35657 35868 +211
- Misses 10195 10412 +217
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <23.56%> (-0.48%)` | :arrow_down: |
| hive | `80.04% <75.00%> (-0.09%)` | :arrow_down: |
| javascript | `63.06% <29.03%> (-0.32%)` | :arrow_down: |
| mysql | `80.34% <73.41%> (-0.12%)` | :arrow_down: |
| postgres | `80.38% <74.68%> (-0.12%)` | :arrow_down: |
| presto | `80.06% <75.00%> (-0.10%)` | :arrow_down: |
| python | `80.89% <75.00%> (-0.11%)` | :arrow_down: |
| sqlite | `79.96% <69.30%> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `36.84% <0.00%> (-2.05%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (ø)` | |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [59 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...e6595a8](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: WIP
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (2a8e6fb) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.33%`.
> The diff coverage is `59.24%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.20% -0.34%
==========================================
Files 904 911 +7
Lines 45986 46388 +402
Branches 5552 5692 +140
==========================================
+ Hits 35657 35814 +157
- Misses 10195 10438 +243
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <23.56%> (-0.48%)` | :arrow_down: |
| hive | `80.02% <75.00%> (-0.11%)` | :arrow_down: |
| javascript | `63.06% <29.03%> (-0.32%)` | :arrow_down: |
| mysql | `80.34% <73.41%> (-0.12%)` | :arrow_down: |
| postgres | `80.38% <74.68%> (-0.12%)` | :arrow_down: |
| presto | `?` | |
| python | `80.76% <75.00%> (-0.24%)` | :arrow_down: |
| sqlite | `79.96% <69.30%> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `36.84% <0.00%> (-2.05%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (ø)` | |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [68 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...e6595a8](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (685fa91) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.24%`.
> The diff coverage is `65.24%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.29% -0.25%
==========================================
Files 904 919 +15
Lines 45986 46713 +727
Branches 5552 5723 +171
==========================================
+ Hits 35657 36108 +451
- Misses 10195 10469 +274
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `80.24% <84.78%> (+0.11%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.23%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.96%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.98% <85.14%> (-0.02%)` | :arrow_down: |
| sqlite | `80.17% <82.24%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [111 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...8cc8f70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (2a8e6fb) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.26%`.
> The diff coverage is `59.24%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.27% -0.27%
==========================================
Files 904 911 +7
Lines 45986 46416 +430
Branches 5552 5692 +140
==========================================
+ Hits 35657 35868 +211
- Misses 10195 10412 +217
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <23.56%> (-0.48%)` | :arrow_down: |
| hive | `80.04% <75.00%> (-0.09%)` | :arrow_down: |
| javascript | `63.06% <29.03%> (-0.32%)` | :arrow_down: |
| mysql | `80.34% <73.41%> (-0.12%)` | :arrow_down: |
| postgres | `80.38% <74.68%> (-0.12%)` | :arrow_down: |
| presto | `80.06% <75.00%> (-0.10%)` | :arrow_down: |
| python | `80.89% <75.00%> (-0.11%)` | :arrow_down: |
| sqlite | `79.96% <69.30%> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `36.84% <0.00%> (-2.05%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (ø)` | |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [59 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...11d7b70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (5460b51) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.29%`.
> The diff coverage is `65.16%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.24% -0.30%
==========================================
Files 904 919 +15
Lines 45986 46712 +726
Branches 5552 5723 +171
==========================================
+ Hits 35657 36084 +427
- Misses 10195 10492 +297
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `80.24% <84.90%> (+0.11%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.18%> (+0.08%)` | :arrow_up: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.89% <85.09%> (-0.11%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [118 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...0bd8f38](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (e73abee) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.18%`.
> The diff coverage is `65.20%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.35% -0.19%
==========================================
Files 904 919 +15
Lines 45986 46713 +727
Branches 5552 5723 +171
==========================================
+ Hits 35657 36135 +478
- Misses 10195 10442 +247
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `80.24% <84.93%> (+0.11%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.21%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.93%> (+0.10%)` | :arrow_up: |
| presto | `80.27% <84.93%> (+0.10%)` | :arrow_up: |
| python | `81.09% <85.11%> (+0.09%)` | :arrow_up: |
| sqlite | `80.17% <82.21%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [111 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...8cc8f70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (d7c0abc) into [master](https://codecov.io/gh/apache/superset/commit/036fc3944d72347dc553d77cb61f179ad7ec3ac3?el=desc) (036fc39) will **decrease** coverage by `5.87%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head d7c0abc differs from pull request most recent head 398e255. Consider uploading reports for the commit 398e255 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.10% 71.22% -5.88%
==========================================
Files 921 839 -82
Lines 46745 41867 -4878
Branches 5733 4334 -1399
==========================================
- Hits 36041 29821 -6220
- Misses 10569 12046 +1477
+ Partials 135 0 -135
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.60% <100.00%> (+<0.01%)` | :arrow_up: |
| hive | `80.24% <76.66%> (?)` | |
| javascript | `?` | |
| mysql | `80.54% <76.66%> (-0.02%)` | :arrow_down: |
| postgres | `80.59% <76.66%> (?)` | |
| python | `80.98% <76.66%> (+0.42%)` | :arrow_up: |
| sqlite | `80.18% <60.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `58.06% <58.06%> (ø)` | |
| [superset/utils/log.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.38% <66.66%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `100.00% <100.00%> (+40.00%)` | :arrow_up: |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.18% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `98.41% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [515 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [036fc39...398e255](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #13601:
URL: https://github.com/apache/superset/pull/13601
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (5460b51) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.18%`.
> The diff coverage is `65.16%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.35% -0.19%
==========================================
Files 904 919 +15
Lines 45986 46712 +726
Branches 5552 5723 +171
==========================================
+ Hits 35657 36134 +477
- Misses 10195 10442 +247
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `80.24% <84.90%> (+0.11%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.18%> (+0.08%)` | :arrow_up: |
| postgres | `80.59% <84.90%> (+0.10%)` | :arrow_up: |
| presto | `80.27% <84.90%> (+0.10%)` | :arrow_up: |
| python | `81.09% <85.09%> (+0.08%)` | :arrow_up: |
| sqlite | `80.17% <82.18%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [111 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...67260de](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (d7c0abc) into [master](https://codecov.io/gh/apache/superset/commit/036fc3944d72347dc553d77cb61f179ad7ec3ac3?el=desc) (036fc39) will **decrease** coverage by `6.05%`.
> The diff coverage is `77.77%`.
> :exclamation: Current head d7c0abc differs from pull request most recent head 398e255. Consider uploading reports for the commit 398e255 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.10% 71.04% -6.06%
==========================================
Files 921 839 -82
Lines 46745 41867 -4878
Branches 5733 4334 -1399
==========================================
- Hits 36041 29746 -6295
- Misses 10569 12121 +1552
+ Partials 135 0 -135
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.60% <100.00%> (+<0.01%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `80.54% <76.66%> (-0.02%)` | :arrow_down: |
| postgres | `80.59% <76.66%> (?)` | |
| python | `80.68% <76.66%> (+0.12%)` | :arrow_up: |
| sqlite | `80.18% <60.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `58.06% <58.06%> (ø)` | |
| [superset/utils/log.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.38% <66.66%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `100.00% <100.00%> (+40.00%)` | :arrow_up: |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.18% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `98.41% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [511 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [036fc39...398e255](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (685fa91) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.40%`.
> The diff coverage is `65.13%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.13% -0.41%
==========================================
Files 904 919 +15
Lines 45986 46713 +727
Branches 5552 5723 +171
==========================================
+ Hits 35657 36033 +376
- Misses 10195 10544 +349
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.23%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.96%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <84.96%> (-0.32%)` | :arrow_down: |
| sqlite | `80.17% <82.24%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [115 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...8cc8f70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: WIP
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (2a8e6fb) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.49%`.
> The diff coverage is `59.04%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.04% -0.50%
==========================================
Files 904 911 +7
Lines 45986 46388 +402
Branches 5552 5692 +140
==========================================
+ Hits 35657 35739 +82
- Misses 10195 10513 +318
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <23.56%> (-0.48%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.06% <29.03%> (-0.32%)` | :arrow_down: |
| mysql | `80.34% <73.41%> (-0.12%)` | :arrow_down: |
| postgres | `80.38% <74.68%> (-0.12%)` | :arrow_down: |
| presto | `?` | |
| python | `80.46% <74.68%> (-0.54%)` | :arrow_down: |
| sqlite | `79.96% <69.30%> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `36.84% <0.00%> (-2.05%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (ø)` | |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [72 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...e6595a8](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: WIP
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (2a8e6fb) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.76%`.
> The diff coverage is `55.66%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 76.77% -0.77%
==========================================
Files 904 911 +7
Lines 45986 46388 +402
Branches 5552 5692 +140
==========================================
- Hits 35657 35613 -44
- Misses 10195 10639 +444
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <23.56%> (-0.48%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.06% <29.03%> (-0.32%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `79.96% <69.30%> (-1.05%)` | :arrow_down: |
| sqlite | `79.96% <69.30%> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `36.84% <0.00%> (-2.05%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (ø)` | |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [87 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...e6595a8](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (5460b51) into [master](https://codecov.io/gh/apache/superset/commit/7b74eb2730a9b0d592de2a4999072f83df193b11?el=desc) (7b74eb2) will **increase** coverage by `4.23%`.
> The diff coverage is `76.56%`.
> :exclamation: Current head 5460b51 differs from pull request most recent head 550db53. Consider uploading reports for the commit 550db53 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
+ Coverage 73.11% 77.35% +4.23%
==========================================
Files 611 919 +308
Lines 21719 46712 +24993
Branches 5644 5723 +79
==========================================
+ Hits 15880 36134 +20254
- Misses 5704 10442 +4738
- Partials 135 136 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <75.00%> (-0.02%)` | :arrow_down: |
| hive | `80.24% <76.66%> (?)` | |
| javascript | `63.04% <0.00%> (-0.11%)` | :arrow_down: |
| mysql | `80.54% <76.66%> (?)` | |
| postgres | `80.59% <76.66%> (?)` | |
| presto | `80.27% <76.66%> (?)` | |
| python | `81.09% <76.66%> (?)` | |
| sqlite | `80.17% <60.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `72.83% <0.00%> (-4.14%)` | :arrow_down: |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `59.37% <59.37%> (ø)` | |
| [superset/utils/log.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.38% <66.66%> (ø)` | |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `66.66% <100.00%> (+6.66%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.18% <100.00%> (ø)` | |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `98.41% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `81.39% <0.00%> (-10.28%)` | :arrow_down: |
| ... and [338 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [036fc39...550db53](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (5460b51) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.26%`.
> The diff coverage is `65.16%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.27% -0.27%
==========================================
Files 904 919 +15
Lines 45986 46712 +726
Branches 5552 5723 +171
==========================================
+ Hits 35657 36096 +439
- Misses 10195 10480 +285
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `80.24% <84.90%> (+0.11%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.18%> (+0.08%)` | :arrow_up: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.93% <85.09%> (-0.07%)` | :arrow_down: |
| sqlite | `80.17% <82.18%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [114 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...0bd8f38](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (e73abee) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `5.01%`.
> The diff coverage is `63.93%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 72.52% -5.02%
==========================================
Files 904 919 +15
Lines 45986 46680 +694
Branches 5552 5723 +171
==========================================
- Hits 35657 33853 -1804
- Misses 10195 12611 +2416
- Partials 134 216 +82
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.21%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.93%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <84.93%> (-0.32%)` | :arrow_down: |
| sqlite | `80.17% <82.21%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `70.00% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `25.00% <0.00%> (-2.59%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `56.52% <0.00%> (-8.70%)` | :arrow_down: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `64.89% <0.00%> (-2.13%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `54.61% <ø> (-5.39%)` | :arrow_down: |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| ... and [328 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...8cc8f70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (f061870) into [master](https://codecov.io/gh/apache/superset/commit/036fc3944d72347dc553d77cb61f179ad7ec3ac3?el=desc) (036fc39) will **decrease** coverage by `3.97%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head f061870 differs from pull request most recent head 550db53. Consider uploading reports for the commit 550db53 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.10% 73.12% -3.98%
==========================================
Files 921 611 -310
Lines 46745 21722 -25023
Branches 5733 5644 -89
==========================================
- Hits 36041 15884 -20157
+ Misses 10569 5703 -4866
Partials 135 135
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.61% <100.00%> (+0.01%)` | :arrow_up: |
| javascript | `63.14% <0.00%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/setup/setupErrorMessages.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | `66.66% <100.00%> (+6.66%)` | :arrow_up: |
| [superset/databases/utils.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3V0aWxzLnB5) | | |
| [superset/utils/webdriver.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvd2ViZHJpdmVyLnB5) | | |
| [superset/models/annotations.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | | |
| [superset/annotation\_layers/schemas.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvc2NoZW1hcy5weQ==) | | |
| [superset/annotation\_layers/commands/create.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvY3JlYXRlLnB5) | | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | | |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | | |
| [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | | |
| ... and [298 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [036fc39...550db53](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (11d7b70) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `5.01%`.
> The diff coverage is `77.04%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 72.52% -5.02%
==========================================
Files 904 919 +15
Lines 45986 46678 +692
Branches 5552 5723 +171
==========================================
- Hits 35657 33853 -1804
- Misses 10195 12609 +2414
- Partials 134 216 +82
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `63.05% <ø> (-0.33%)` | :arrow_down: |
| mysql | `80.54% <77.04%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <77.04%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <77.04%> (-0.32%)` | :arrow_down: |
| sqlite | `80.17% <60.65%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/utils/network.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbmV0d29yay5weQ==) | `59.37% <59.37%> (ø)` | |
| [superset/utils/log.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.38% <66.66%> (-0.65%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (+0.09%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.18% <100.00%> (+0.49%)` | :arrow_up: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `98.43% <100.00%> (+0.52%)` | :arrow_up: |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [276 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...11d7b70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (5460b51) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.24%`.
> The diff coverage is `65.16%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.29% -0.25%
==========================================
Files 904 919 +15
Lines 45986 46712 +726
Branches 5552 5723 +171
==========================================
+ Hits 35657 36106 +449
- Misses 10195 10470 +275
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `80.24% <84.90%> (+0.11%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.18%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.90%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.97% <85.09%> (-0.03%)` | :arrow_down: |
| sqlite | `80.17% <82.18%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [112 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...0bd8f38](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (5460b51) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.24%`.
> The diff coverage is `65.16%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.29% -0.25%
==========================================
Files 904 919 +15
Lines 45986 46712 +726
Branches 5552 5723 +171
==========================================
+ Hits 35657 36107 +450
- Misses 10195 10469 +274
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `80.24% <84.90%> (+0.11%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.18%> (+0.08%)` | :arrow_up: |
| postgres | `80.59% <84.90%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.98% <85.09%> (-0.02%)` | :arrow_down: |
| sqlite | `80.17% <82.18%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [111 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...0bd8f38](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: WIP
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (2a8e6fb) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.52%`.
> The diff coverage is `58.25%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.00% -0.53%
==========================================
Files 904 911 +7
Lines 45986 46388 +402
Branches 5552 5692 +140
==========================================
+ Hits 35657 35723 +66
- Misses 10195 10529 +334
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <23.56%> (-0.48%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.06% <29.03%> (-0.32%)` | :arrow_down: |
| mysql | `80.34% <73.41%> (-0.12%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.40% <73.41%> (-0.60%)` | :arrow_down: |
| sqlite | `79.96% <69.30%> (-0.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `36.84% <0.00%> (-2.05%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (ø)` | |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [75 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...e6595a8](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13601: feat: better error message when adding DBs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13601:
URL: https://github.com/apache/superset/pull/13601#issuecomment-797623969
# [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=h1) Report
> Merging [#13601](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=desc) (e73abee) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `0.24%`.
> The diff coverage is `65.20%`.
[](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13601 +/- ##
==========================================
- Coverage 77.53% 77.29% -0.25%
==========================================
Files 904 919 +15
Lines 45986 46713 +727
Branches 5552 5723 +171
==========================================
+ Hits 35657 36108 +451
- Misses 10195 10469 +274
- Partials 134 136 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.58% <21.63%> (-0.63%)` | :arrow_down: |
| hive | `80.22% <84.93%> (+0.09%)` | :arrow_up: |
| javascript | `63.04% <29.79%> (-0.34%)` | :arrow_down: |
| mysql | `80.54% <84.21%> (+0.08%)` | :arrow_up: |
| postgres | `80.60% <84.93%> (+0.10%)` | :arrow_up: |
| presto | `?` | |
| python | `80.98% <85.11%> (-0.02%)` | :arrow_down: |
| sqlite | `80.17% <82.21%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `28.57% <0.00%> (+0.98%)` | :arrow_up: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ø> (ø)` | |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `67.02% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `22.58% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `58.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| ... and [111 more](https://codecov.io/gh/apache/superset/pull/13601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=footer). Last update [5fca19d...8cc8f70](https://codecov.io/gh/apache/superset/pull/13601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org