You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2016/03/22 01:59:25 UTC
Review Request 45140: Hive interactive component should be
created/deleted when interactive query is enabled/disabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45140/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Swapan Shridhar, and Yusaku Sako.
Bugs: AMBARI-15503
https://issues.apache.org/jira/browse/AMBARI-15503
Repository: ambari
Description
-------
1. Show dialog to user for choosing HiveServer2 interactive host component when Interactive query is turned ON
2. If Manual kerberos is enabled on the cluster then the dialog should ask user to add appropriate keytabs for newly installed host components
3. HiveServer2 interactive host-component and its dependencies should be created and started when "Enable Interactive" flag is turned ON.
4. HiveServer2 interactive host-component should be stopped and deleted when "Enable Interactive" flag is turned OFF.
5. UI should ask user to install slider service if not present in the cluster
6. "Enable Interactive" flag should be disabled when installing another service.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml fb55d2d
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/llap-env.xml 24a95cf
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml ff0f318
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/themes/theme.json 26b9532
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/themes/theme_version_2.json PRE-CREATION
ambari-web/app/controllers/main/service/info/configs.js 93775fb
ambari-web/app/controllers/wizard/step7/assign_master_controller.js 496968b
ambari-web/app/controllers/wizard/step7_controller.js 06488b1
ambari-web/app/mappers/configs/themes_mapper.js 3e68e67
ambari-web/app/messages.js 421143a
ambari-web/app/mixins.js 0a686b3
ambari-web/app/mixins/common/configs/configs_saver.js 82741fa
ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js PRE-CREATION
ambari-web/app/mixins/wizard/assign_master_components.js 78af279
ambari-web/app/models/configs/theme/config_action.js 288c674
ambari-web/app/templates/common/assign_master_components.hbs ea77c73
ambari-web/app/templates/common/configs/widgets/label_config_widget.hbs PRE-CREATION
ambari-web/app/utils/ajax/ajax.js 4e7b045
ambari-web/app/utils/configs/theme/theme.js f0cf966
ambari-web/app/views.js 8e8154c
ambari-web/app/views/common/assign_master_components_view.js da45ee9
ambari-web/app/views/common/configs/service_config_layout_tab_view.js def75d1
ambari-web/app/views/common/configs/widgets/config_widget_view.js 3ad9e3b
ambari-web/app/views/common/configs/widgets/label_config_widget_view.js PRE-CREATION
ambari-web/app/views/common/configs/widgets/time_interval_spinner_view.js 8663ac3
ambari-web/app/views/wizard/step7/assign_master_view.js 2bc2ce3
ambari-web/test/controllers/wizard/step5_test.js 4140210
ambari-web/test/mixins/wizard/assign_master_components_test.js ecdb456
Diff: https://reviews.apache.org/r/45140/diff/
Testing
-------
Manually tested the patch on Installer, Add Service wizard and service->config page
Verified that all ambari-web unit tests passes:
24639 tests complete (34 seconds)
145 tests pending
Thanks,
Jaimin Jetly
Re: Review Request 45140: Hive interactive component should be
created/deleted when interactive query is enabled/disabled
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45140/#review124696
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml (lines 2052 - 2060)
<https://reviews.apache.org/r/45140/#comment187326>
Llap related properties will be updated with appropriate description as part of AMBARI-15502 task
- Jaimin Jetly
On March 22, 2016, 12:59 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45140/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 12:59 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Swapan Shridhar, and Yusaku Sako.
>
>
> Bugs: AMBARI-15503
> https://issues.apache.org/jira/browse/AMBARI-15503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Show dialog to user for choosing HiveServer2 interactive host component when Interactive query is turned ON
> 2. If Manual kerberos is enabled on the cluster then the dialog should ask user to add appropriate keytabs for newly installed host components
> 3. HiveServer2 interactive host-component and its dependencies should be created and started when "Enable Interactive" flag is turned ON.
> 4. HiveServer2 interactive host-component should be stopped and deleted when "Enable Interactive" flag is turned OFF.
> 5. UI should ask user to install slider service if not present in the cluster
> 6. "Enable Interactive" flag should be disabled when installing another service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml fb55d2d
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/llap-env.xml 24a95cf
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml ff0f318
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/themes/theme.json 26b9532
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/themes/theme_version_2.json PRE-CREATION
> ambari-web/app/controllers/main/service/info/configs.js 93775fb
> ambari-web/app/controllers/wizard/step7/assign_master_controller.js 496968b
> ambari-web/app/controllers/wizard/step7_controller.js 06488b1
> ambari-web/app/mappers/configs/themes_mapper.js 3e68e67
> ambari-web/app/messages.js 421143a
> ambari-web/app/mixins.js 0a686b3
> ambari-web/app/mixins/common/configs/configs_saver.js 82741fa
> ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js PRE-CREATION
> ambari-web/app/mixins/wizard/assign_master_components.js 78af279
> ambari-web/app/models/configs/theme/config_action.js 288c674
> ambari-web/app/templates/common/assign_master_components.hbs ea77c73
> ambari-web/app/templates/common/configs/widgets/label_config_widget.hbs PRE-CREATION
> ambari-web/app/utils/ajax/ajax.js 4e7b045
> ambari-web/app/utils/configs/theme/theme.js f0cf966
> ambari-web/app/views.js 8e8154c
> ambari-web/app/views/common/assign_master_components_view.js da45ee9
> ambari-web/app/views/common/configs/service_config_layout_tab_view.js def75d1
> ambari-web/app/views/common/configs/widgets/config_widget_view.js 3ad9e3b
> ambari-web/app/views/common/configs/widgets/label_config_widget_view.js PRE-CREATION
> ambari-web/app/views/common/configs/widgets/time_interval_spinner_view.js 8663ac3
> ambari-web/app/views/wizard/step7/assign_master_view.js 2bc2ce3
> ambari-web/test/controllers/wizard/step5_test.js 4140210
> ambari-web/test/mixins/wizard/assign_master_components_test.js ecdb456
>
> Diff: https://reviews.apache.org/r/45140/diff/
>
>
> Testing
> -------
>
> Manually tested the patch on Installer, Add Service wizard and service->config page
> Verified that all ambari-web unit tests passes:
>
> 24639 tests complete (34 seconds)
> 145 tests pending
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 45140: Hive interactive component should be
created/deleted when interactive query is enabled/disabled
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45140/#review124723
-----------------------------------------------------------
Ship it!
LGTM for "role_command_order.json", "hive-interactive-env.xml" and "hive-interactive-site.xml".
- Swapan Shridhar
On March 22, 2016, 1:30 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45140/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 1:30 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Swapan Shridhar, and Yusaku Sako.
>
>
> Bugs: AMBARI-15503
> https://issues.apache.org/jira/browse/AMBARI-15503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Show dialog to user for choosing HiveServer2 interactive host component when Interactive query is turned ON
> 2. If Manual kerberos is enabled on the cluster then the dialog should ask user to add appropriate keytabs for newly installed host components
> 3. HiveServer2 interactive host-component and its dependencies should be created and started when "Enable Interactive" flag is turned ON.
> 4. HiveServer2 interactive host-component should be stopped and deleted when "Enable Interactive" flag is turned OFF.
> 5. UI should ask user to install slider service if not present in the cluster
> 6. "Enable Interactive" flag should be disabled when installing another service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml fb55d2d
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/llap-env.xml 24a95cf
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml ff0f318
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/themes/theme.json 26b9532
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/themes/theme_version_2.json PRE-CREATION
> ambari-web/app/controllers/main/service/info/configs.js 93775fb
> ambari-web/app/controllers/wizard/step7/assign_master_controller.js 496968b
> ambari-web/app/controllers/wizard/step7_controller.js 06488b1
> ambari-web/app/mappers/configs/themes_mapper.js 3e68e67
> ambari-web/app/messages.js 421143a
> ambari-web/app/mixins.js 0a686b3
> ambari-web/app/mixins/common/configs/configs_saver.js 82741fa
> ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js PRE-CREATION
> ambari-web/app/mixins/wizard/assign_master_components.js 78af279
> ambari-web/app/models/configs/theme/config_action.js 288c674
> ambari-web/app/templates/common/assign_master_components.hbs ea77c73
> ambari-web/app/templates/common/configs/widgets/label_config_widget.hbs PRE-CREATION
> ambari-web/app/utils/ajax/ajax.js 4e7b045
> ambari-web/app/utils/configs/theme/theme.js f0cf966
> ambari-web/app/views.js 8e8154c
> ambari-web/app/views/common/assign_master_components_view.js da45ee9
> ambari-web/app/views/common/configs/service_config_layout_tab_view.js def75d1
> ambari-web/app/views/common/configs/widgets/config_widget_view.js 3ad9e3b
> ambari-web/app/views/common/configs/widgets/label_config_widget_view.js PRE-CREATION
> ambari-web/app/views/common/configs/widgets/time_interval_spinner_view.js 8663ac3
> ambari-web/app/views/wizard/step7/assign_master_view.js 2bc2ce3
> ambari-web/test/controllers/wizard/step5_test.js 4140210
> ambari-web/test/mixins/wizard/assign_master_components_test.js ecdb456
>
> Diff: https://reviews.apache.org/r/45140/diff/
>
>
> Testing
> -------
>
> Manually tested the patch on Installer, Add Service wizard and service->config page
> Verified that all ambari-web unit tests passes:
>
> 24639 tests complete (34 seconds)
> 145 tests pending
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 45140: Hive interactive component should be
created/deleted when interactive query is enabled/disabled
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45140/#review124734
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On March 22, 2016, 1:30 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45140/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 1:30 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Swapan Shridhar, and Yusaku Sako.
>
>
> Bugs: AMBARI-15503
> https://issues.apache.org/jira/browse/AMBARI-15503
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Show dialog to user for choosing HiveServer2 interactive host component when Interactive query is turned ON
> 2. If Manual kerberos is enabled on the cluster then the dialog should ask user to add appropriate keytabs for newly installed host components
> 3. HiveServer2 interactive host-component and its dependencies should be created and started when "Enable Interactive" flag is turned ON.
> 4. HiveServer2 interactive host-component should be stopped and deleted when "Enable Interactive" flag is turned OFF.
> 5. UI should ask user to install slider service if not present in the cluster
> 6. "Enable Interactive" flag should be disabled when installing another service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml fb55d2d
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/llap-env.xml 24a95cf
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml ff0f318
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/themes/theme.json 26b9532
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/themes/theme_version_2.json PRE-CREATION
> ambari-web/app/controllers/main/service/info/configs.js 93775fb
> ambari-web/app/controllers/wizard/step7/assign_master_controller.js 496968b
> ambari-web/app/controllers/wizard/step7_controller.js 06488b1
> ambari-web/app/mappers/configs/themes_mapper.js 3e68e67
> ambari-web/app/messages.js 421143a
> ambari-web/app/mixins.js 0a686b3
> ambari-web/app/mixins/common/configs/configs_saver.js 82741fa
> ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js PRE-CREATION
> ambari-web/app/mixins/wizard/assign_master_components.js 78af279
> ambari-web/app/models/configs/theme/config_action.js 288c674
> ambari-web/app/templates/common/assign_master_components.hbs ea77c73
> ambari-web/app/templates/common/configs/widgets/label_config_widget.hbs PRE-CREATION
> ambari-web/app/utils/ajax/ajax.js 4e7b045
> ambari-web/app/utils/configs/theme/theme.js f0cf966
> ambari-web/app/views.js 8e8154c
> ambari-web/app/views/common/assign_master_components_view.js da45ee9
> ambari-web/app/views/common/configs/service_config_layout_tab_view.js def75d1
> ambari-web/app/views/common/configs/widgets/config_widget_view.js 3ad9e3b
> ambari-web/app/views/common/configs/widgets/label_config_widget_view.js PRE-CREATION
> ambari-web/app/views/common/configs/widgets/time_interval_spinner_view.js 8663ac3
> ambari-web/app/views/wizard/step7/assign_master_view.js 2bc2ce3
> ambari-web/test/controllers/wizard/step5_test.js 4140210
> ambari-web/test/mixins/wizard/assign_master_components_test.js ecdb456
>
> Diff: https://reviews.apache.org/r/45140/diff/
>
>
> Testing
> -------
>
> Manually tested the patch on Installer, Add Service wizard and service->config page
> Verified that all ambari-web unit tests passes:
>
> 24639 tests complete (34 seconds)
> 145 tests pending
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 45140: Hive interactive component should be
created/deleted when interactive query is enabled/disabled
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45140/
-----------------------------------------------------------
(Updated March 22, 2016, 1:30 a.m.)
Review request for Ambari, Srimanth Gunturi, Swapan Shridhar, and Yusaku Sako.
Changes
-------
small fix related to deletion of hive interactive component on disbaling interactive query.
Bugs: AMBARI-15503
https://issues.apache.org/jira/browse/AMBARI-15503
Repository: ambari
Description
-------
1. Show dialog to user for choosing HiveServer2 interactive host component when Interactive query is turned ON
2. If Manual kerberos is enabled on the cluster then the dialog should ask user to add appropriate keytabs for newly installed host components
3. HiveServer2 interactive host-component and its dependencies should be created and started when "Enable Interactive" flag is turned ON.
4. HiveServer2 interactive host-component should be stopped and deleted when "Enable Interactive" flag is turned OFF.
5. UI should ask user to install slider service if not present in the cluster
6. "Enable Interactive" flag should be disabled when installing another service.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml fb55d2d
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/llap-env.xml 24a95cf
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml ff0f318
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/themes/theme.json 26b9532
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/themes/theme_version_2.json PRE-CREATION
ambari-web/app/controllers/main/service/info/configs.js 93775fb
ambari-web/app/controllers/wizard/step7/assign_master_controller.js 496968b
ambari-web/app/controllers/wizard/step7_controller.js 06488b1
ambari-web/app/mappers/configs/themes_mapper.js 3e68e67
ambari-web/app/messages.js 421143a
ambari-web/app/mixins.js 0a686b3
ambari-web/app/mixins/common/configs/configs_saver.js 82741fa
ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js PRE-CREATION
ambari-web/app/mixins/wizard/assign_master_components.js 78af279
ambari-web/app/models/configs/theme/config_action.js 288c674
ambari-web/app/templates/common/assign_master_components.hbs ea77c73
ambari-web/app/templates/common/configs/widgets/label_config_widget.hbs PRE-CREATION
ambari-web/app/utils/ajax/ajax.js 4e7b045
ambari-web/app/utils/configs/theme/theme.js f0cf966
ambari-web/app/views.js 8e8154c
ambari-web/app/views/common/assign_master_components_view.js da45ee9
ambari-web/app/views/common/configs/service_config_layout_tab_view.js def75d1
ambari-web/app/views/common/configs/widgets/config_widget_view.js 3ad9e3b
ambari-web/app/views/common/configs/widgets/label_config_widget_view.js PRE-CREATION
ambari-web/app/views/common/configs/widgets/time_interval_spinner_view.js 8663ac3
ambari-web/app/views/wizard/step7/assign_master_view.js 2bc2ce3
ambari-web/test/controllers/wizard/step5_test.js 4140210
ambari-web/test/mixins/wizard/assign_master_components_test.js ecdb456
Diff: https://reviews.apache.org/r/45140/diff/
Testing
-------
Manually tested the patch on Installer, Add Service wizard and service->config page
Verified that all ambari-web unit tests passes:
24639 tests complete (34 seconds)
145 tests pending
Thanks,
Jaimin Jetly