You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/03/01 05:06:54 UTC
[GitHub] [systemml] HannanKan opened a new pull request #866:
[SYSTEMML-2533] Error in running MNIST LeNet algorithm
HannanKan opened a new pull request #866: [SYSTEMML-2533] Error in running MNIST LeNet algorithm
URL: https://github.com/apache/systemml/pull/866
Fix bug in issue [SYSTEMML-2533] https://issues.apache.org/jira/projects/SYSTEMML/issues/SYSTEMML-2533?filter=allopenissues. This bug is caused by wrong DML script in `systemml-master/scripts/nn/examples/mnist_lenet.dml`. I explain it in JIRA "https://issues.apache.org/jira/projects/SYSTEMML/issues/SYSTEMML-2533?filter=allopenissues" comment in detail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] mboehm7 commented on issue #866: [SYSTEMML-2533] Error
in running MNIST LeNet algorithm
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on issue #866: [SYSTEMML-2533] Error in running MNIST LeNet algorithm
URL: https://github.com/apache/systemml/pull/866#issuecomment-593146440
LGTM. Thanks for catching this issue @HannanKan. You're right and the reason for the conflict is that the related script max_pool2d_builtin::forward defines padh and padw but no pad. So, it might better to simply change the argument names at the calling sites.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] HannanKan commented on issue #866: [SYSTEMML-2533] Error
in running MNIST LeNet algorithm
Posted by GitBox <gi...@apache.org>.
HannanKan commented on issue #866: [SYSTEMML-2533] Error in running MNIST LeNet algorithm
URL: https://github.com/apache/systemml/pull/866#issuecomment-593184435
> LGTM. Thanks for catching this issue @HannanKan. You're right and the reason for the conflict is that the related script max_pool2d_builtin::forward defines padh and padw but no pad. So, it might better to simply change the argument names at the calling sites.
You are right. I have change the parameter name in the new pull request .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] asfgit closed pull request #866: [SYSTEMML-2533] Error
in running MNIST LeNet algorithm
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #866: [SYSTEMML-2533] Error in running MNIST LeNet algorithm
URL: https://github.com/apache/systemml/pull/866
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [systemml] mboehm7 commented on issue #866: [SYSTEMML-2533] Error
in running MNIST LeNet algorithm
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on issue #866: [SYSTEMML-2533] Error in running MNIST LeNet algorithm
URL: https://github.com/apache/systemml/pull/866#issuecomment-593146612
Also could you please associate your github account with the email of your commit or change your commit so you get properly linked when merging this in. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services