You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "lkishalmi (via GitHub)" <gi...@apache.org> on 2023/10/03 01:49:55 UTC
[PR] Removed a few defunct Gradle Settings [netbeans]
lkishalmi opened a new pull request, #6516:
URL: https://github.com/apache/netbeans/pull/6516
Removed the following no-more useful Settings from Gradle:
- Start Gradle Daemon on IDE Start
In the early days (2.x,3.x) it could have saved a few seconds, by loading the Daemon early, however in those days the Wrapper was not commonly used. Usually every project were used with one Gradle version set in the IDE. Project loading was also done by that daemon. Today, there is no advantage to fire up a Gradle Daemon which most likely won't be used.
- Install Gradle Runtime Silently
It started to download a new Gradle version when it was selected in the settings dialog right when the dialog settings were applied. It could save a few seconds in the old days. Today it is usually done by the wrapper, and the project trust replaced this functionality.
- Do not Rebuild Project Dependencies
In the older days, this was a real performance boost working on projects. Right now the flag state is, I'd say undecided. It got removed in `Gradle 8.0` without deprecation, got restored in `Gradle 8.0.1`. There is no sigh of deprecation since then. We put it in deprecated on NB18 for the option removal in NB20. It still can be used if someone overwrite the Gradle actions, but it's better to leave this option out.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Removed a few defunct Gradle Settings [netbeans]
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on PR #6516:
URL: https://github.com/apache/netbeans/pull/6516#issuecomment-1763187751
I've started to work on removing the Grade version selector and adding a default java runtime instead. I hope I can submit that work on this branch tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Removed a few defunct Gradle Settings [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #6516:
URL: https://github.com/apache/netbeans/pull/6516#issuecomment-1762887043
wanted to merge but seeing two unresolved reviewer comments, freeze is on the 17th.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Removed a few defunct Gradle Settings [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #6516:
URL: https://github.com/apache/netbeans/pull/6516#issuecomment-1764317724
as discussed on apache slack, going to add a commit which fixes some minor layout issues. Some show up right away, some are only visible when the window is resized:



--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Removed a few defunct Gradle Settings [netbeans]
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi merged PR #6516:
URL: https://github.com/apache/netbeans/pull/6516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Removed a few defunct Gradle Settings [netbeans]
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on PR #6516:
URL: https://github.com/apache/netbeans/pull/6516#issuecomment-1763885828

Further cleanup, removed the option to select the Gradle version, added default Java Runtime selection for Gradle execution.
There could be further enhancements, around warnings and auto selecting the proper JDK for Gradle Execution, but this is how far I could go before NB20 window closes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Removed a few defunct Gradle Settings [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on code in PR #6516:
URL: https://github.com/apache/netbeans/pull/6516#discussion_r1343567503
##########
extide/gradle/apichanges.xml:
##########
@@ -83,6 +83,21 @@ is the proper place.
<!-- ACTUAL CHANGES BEGIN HERE: -->
<changes>
+ <change id="gradle-setting-deprecation">
+ <api name="general"/>
+ <summary>Some Gradle Settings Removed from Use</summary>
+ <version major="2" minor="36"/>
+ <date day="2" month="10" year="2023"/>
+ <author login="lkishalmi"/>
+ <compatibility semantic="compatible" />
Review Comment:
IMHO semantic should be `incompatible`: code that hopes the setter (setting) has some effect may break.
##########
extide/gradle/src/org/netbeans/modules/gradle/spi/GradleSettings.java:
##########
@@ -182,12 +185,24 @@ public File getGradleUserHome() {
return dir != null ? new File(dir) : new File(System.getProperty("user.home"), ".gradle"); //NOI18N
}
+ /**
+ * Not in use.
+ * @param b
+ * @deprecated
+ */
+ @Deprecated
Review Comment:
Consider to log a `WARNING`-level message in the setters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists