You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/01/08 19:30:49 UTC
[GitHub] [thrift] fishy commented on pull request #2497: THRIFT-5495: close client when shutdown server in go lib
fishy commented on pull request #2497:
URL: https://github.com/apache/thrift/pull/2497#issuecomment-1008118138
actually we already have race detector enabled on travis and it's falling (https://app.travis-ci.com/github/apache/thrift/jobs/554765808):
```
make[4]: Entering directory '/thrift/src/lib/go'
/usr/local/bin/go test -mod=mod -race ./thrift
==================
WARNING: DATA RACE
Read at 0x00c000509580 by goroutine 92:
github.com/apache/thrift/lib/go/thrift.(*TSocket).Close()
/thrift/src/lib/go/thrift/socket.go:198 +0x32
github.com/apache/thrift/lib/go/thrift.(*TSimpleServer).processRequests·dwrap·15()
/thrift/src/lib/go/thrift/simple_server.go:307 +0x48
github.com/apache/thrift/lib/go/thrift.(*TSimpleServer).processRequests()
/thrift/src/lib/go/thrift/simple_server.go:349 +0x8ce
github.com/apache/thrift/lib/go/thrift.(*TSimpleServer).innerAccept.func1()
/thrift/src/lib/go/thrift/simple_server.go:203 +0x108
Previous write at 0x00c000509580 by goroutine 130:
github.com/apache/thrift/lib/go/thrift.(*TSocket).Close()
/thrift/src/lib/go/thrift/socket.go:203 +0x79
github.com/apache/thrift/lib/go/thrift.(*TSimpleServer).innerAccept.func2()
/thrift/src/lib/go/thrift/simple_server.go:215 +0x1a1
Goroutine 92 (running) created at:
github.com/apache/thrift/lib/go/thrift.(*TSimpleServer).innerAccept()
/thrift/src/lib/go/thrift/simple_server.go:200 +0x296
github.com/apache/thrift/lib/go/thrift.(*TSimpleServer).AcceptLoop()
/thrift/src/lib/go/thrift/simple_server.go:224 +0xee
github.com/apache/thrift/lib/go/thrift.(*TSimpleServer).Serve()
/thrift/src/lib/go/thrift/simple_server.go:241 +0xbd
github.com/apache/thrift/lib/go/thrift.TestNoHangDuringStopFromClientNoDataSendDuringAcceptLoop·dwrap·31()
/thrift/src/lib/go/thrift/simple_server_test.go:191 +0x39
Goroutine 130 (finished) created at:
github.com/apache/thrift/lib/go/thrift.(*TSimpleServer).innerAccept()
/thrift/src/lib/go/thrift/simple_server.go:208 +0x396
github.com/apache/thrift/lib/go/thrift.(*TSimpleServer).AcceptLoop()
/thrift/src/lib/go/thrift/simple_server.go:224 +0xee
github.com/apache/thrift/lib/go/thrift.(*TSimpleServer).Serve()
/thrift/src/lib/go/thrift/simple_server.go:241 +0xbd
github.com/apache/thrift/lib/go/thrift.TestNoHangDuringStopFromClientNoDataSendDuringAcceptLoop·dwrap·31()
/thrift/src/lib/go/thrift/simple_server_test.go:191 +0x39
==================
--- FAIL: TestNoHangDuringStopFromClientNoDataSendDuringAcceptLoop (0.02s)
testing.go:1152: race detected during execution of test
FAIL
FAIL github.com/apache/thrift/lib/go/thrift 2.081s
FAIL
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org