You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "camphillips22 (via GitHub)" <gi...@apache.org> on 2024/05/03 16:16:38 UTC
[PR] WIP: pane [beam]
camphillips22 opened a new pull request, #31174:
URL: https://github.com/apache/beam/pull/31174
WIP attempt to handle panes correctly.
TODO:
- [ ] Ensure that PaneInfo is actually being decoded correctly.
Fixes: #31153
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [Go SDK] Handle PaneInfo correctly [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31174:
URL: https://github.com/apache/beam/pull/31174#issuecomment-2217606573
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [Go SDK] Handle PaneInfo correctly [beam]
Posted by "camphillips22 (via GitHub)" <gi...@apache.org>.
camphillips22 commented on code in PR #31174:
URL: https://github.com/apache/beam/pull/31174#discussion_r1589421878
##########
sdks/go/pkg/beam/runners/prism/internal/coders.go:
##########
@@ -187,6 +187,30 @@ func reconcileCoders(bundle, base map[string]*pipepb.Coder) {
}
}
+func reconcileWindowCoders(bundle, base map[string]*pipepb.Coder, ws map[string]*pipepb.WindowingStrategy) {
Review Comment:
I might open a separate PR for this, but this happens because the coder passed through the instruction is not included when there are multiple windowing strategies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [Go SDK] Handle PaneInfo correctly [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31174:
URL: https://github.com/apache/beam/pull/31174#issuecomment-2233232183
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [Go SDK] Handle PaneInfo correctly [beam]
Posted by "camphillips22 (via GitHub)" <gi...@apache.org>.
camphillips22 commented on code in PR #31174:
URL: https://github.com/apache/beam/pull/31174#discussion_r1589421878
##########
sdks/go/pkg/beam/runners/prism/internal/coders.go:
##########
@@ -187,6 +187,30 @@ func reconcileCoders(bundle, base map[string]*pipepb.Coder) {
}
}
+func reconcileWindowCoders(bundle, base map[string]*pipepb.Coder, ws map[string]*pipepb.WindowingStrategy) {
Review Comment:
I might open a separate PR for this, but without this, prism will error because the coder passed through the instruction is not included when there are multiple windowing strategies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [Go SDK] Handle PaneInfo correctly [beam]
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on code in PR #31174:
URL: https://github.com/apache/beam/pull/31174#discussion_r1595736127
##########
sdks/go/test/integration/primitives/window_panes_test.go:
##########
@@ -26,3 +26,8 @@ func TestPanes(t *testing.T) {
integration.CheckFilters(t)
ptest.BuildAndRun(t, Panes)
}
+
+func TestPanesNonStreaming(t *testing.T) {
Review Comment:
Just a drive-by: I'm uncertain how the different runners will treat panes in batch execution.
Triggers are more complicated than they appear, so thanks for giving this a go!
I know if they work, Flink will execute them correctly, regardless of Pipeline "mode" (batch or streaming), Dataflow might have different behavior for panes for Batch and Streaming pipelines.
Prism (the local runner), doesn't yet do anything with Panes, as it doesn't currently support triggers, which is the only material thing that mutates panes AFAICT.
My recommendation is making sure you get your expected behavior from Flink and Dataflow executions first, before trying to get Prism working (you might already be at this point, I see some changes to prism).
Do @mention me if you have questions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [Go SDK] Handle PaneInfo correctly [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #31174: WIP: [Go SDK] Handle PaneInfo correctly
URL: https://github.com/apache/beam/pull/31174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org