You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/12/08 23:05:33 UTC
Review Request 54555: Removed using declarations in headers in global
scope in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54555/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/posix/subprocess.hpp 60f40eada741b1caf81247a396a179e2b7d79ac0
3rdparty/libprocess/include/process/windows/subprocess.hpp e2ba7526b65b0a88cb297ec7cf52701f27b1abd0
Diff: https://reviews.apache.org/r/54555/diff/
Testing
-------
`make check` (OS X, clang w/ libc++, various Linux setups in internal CI)
Thanks,
Benjamin Bannier
Re: Review Request 54555: Removed using declarations in headers in
global scope in libprocess.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54555/#review158677
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Dec. 8, 2016, 11:05 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54555/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 11:05 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/posix/subprocess.hpp 60f40eada741b1caf81247a396a179e2b7d79ac0
> 3rdparty/libprocess/include/process/windows/subprocess.hpp e2ba7526b65b0a88cb297ec7cf52701f27b1abd0
>
> Diff: https://reviews.apache.org/r/54555/diff/
>
>
> Testing
> -------
>
> `make check` (OS X, clang w/ libc++, various Linux setups in internal CI)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 54555: Removed using declarations in headers in
global scope in libprocess.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54555/#review158624
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54553, 54554, 54555]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 8, 2016, 11:05 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54555/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 11:05 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/posix/subprocess.hpp 60f40eada741b1caf81247a396a179e2b7d79ac0
> 3rdparty/libprocess/include/process/windows/subprocess.hpp e2ba7526b65b0a88cb297ec7cf52701f27b1abd0
>
> Diff: https://reviews.apache.org/r/54555/diff/
>
>
> Testing
> -------
>
> `make check` (OS X, clang w/ libc++, various Linux setups in internal CI)
>
>
> Thanks,
>
> Benjamin Bannier
>
>