You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/04 05:27:04 UTC
[jira] [Commented] (SAMZA-1228) StreamProcessor should stop
JmxServer
[ https://issues.apache.org/jira/browse/SAMZA-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996187#comment-15996187 ]
ASF GitHub Bot commented on SAMZA-1228:
---------------------------------------
GitHub user navina opened a pull request:
https://github.com/apache/samza/pull/162
SAMZA-1228 : StreamProcessor should stop JmxServer
This is not the solution posted in SAMZA-1228. For now, we are moving jmxserver lifecycle to be within the container. Ideally, it should be within the Streamprocessor so that the job coordinator can also be associated with the same instance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/navina/samza SAMZA-1228
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/162.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #162
----
commit 13a44dbaa8432125cdc2eebc184fe683b4e615d5
Author: Navina Ramesh <na...@apache.org>
Date: 2017-05-04T04:44:26Z
SAMZA-1228 : StreamProcessor should stop JmxServer
----
> StreamProcessor should stop JmxServer
> -------------------------------------
>
> Key: SAMZA-1228
> URL: https://issues.apache.org/jira/browse/SAMZA-1228
> Project: Samza
> Issue Type: Bug
> Reporter: Navina Ramesh
> Assignee: Navina Ramesh
> Fix For: 0.13.0
>
>
> When StreamProcessor was created, it , by default, creates a new JmxServer for the container instance. However, it is not shutdown by the container or by the StreamProcessor.
> Two changes need to be made:
> 1. StreamProcessor should not create a JmxServer unless it is explicitly passed by the user-facing api (ApplicationRunner / JobRunner)
> 2. When the processor is shutdown, the caller should shutdown the JmxServer
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)