[GitHub] [beam] kennknowles commented on pull request #14226: Make beam_fn_api, use_runner_v2, and use_unified_worker all trigger the same behavior in the SDK

[GitBox <gi...@apache.org>]

kennknowles commented on pull request #14226:
URL: https://github.com/apache/beam/pull/14226#issuecomment-799622660


   I think it is a "change detector" test that is sensitive to the exact v1beta3 graph.
   
   The test only sets `beam_fn_api` but not `use_unified_worker`. So it would not use the portable expansion for side inputs. Now it will use the portable expansion, so the translation is different.
   
   Previously, I made this same change and threw away the branch because of this failure. Now that we use portable job submission and unified worker all the time with `beam_fn_api`, we can delete all of these tests that only would apply to JRH.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org