You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by smola <gi...@git.apache.org> on 2015/04/11 13:09:10 UTC
[GitHub] spark pull request: [SPARK-6741][SQL] Add support for SELECT ALL s...
GitHub user smola opened a pull request:
https://github.com/apache/spark/pull/5469
[SPARK-6741][SQL] Add support for SELECT ALL syntax.
https://issues.apache.org/jira/browse/SPARK-6741
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smola/spark feature/select-all
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5469.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5469
----
commit 3cdee0cf6d8dec2a0e646f60758ccd097f30a92d
Author: Santiago M. Mola <sa...@sap.com>
Date: 2015-04-11T11:07:47Z
[SPARK-6741][SQL] Add support for SELECT ALL syntax.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6741][SQL] Add support for SELECT ALL s...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5469#issuecomment-91947401
Thanks for the contribution, but I'm pretty hesitant to add unnecessary syntax to the SQL parser. One reason is that each new keyword actually could break existing code. Any user that has a column named `all` would now need to start using backticks. Is there a strong reason to add this that I'm missing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6741][SQL] Add support for SELECT ALL s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5469#issuecomment-91946403
[Test build #30089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30089/consoleFull) for PR 5469 at commit [`3cdee0c`](https://github.com/apache/spark/commit/3cdee0cf6d8dec2a0e646f60758ccd097f30a92d).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6741][SQL] Add support for SELECT ALL s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5469#issuecomment-96767380
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6741][SQL] Add support for SELECT ALL s...
Posted by smola <gi...@git.apache.org>.
Github user smola commented on the pull request:
https://github.com/apache/spark/pull/5469#issuecomment-94496369
@marmbrus Maybe this and https://github.com/apache/spark/pull/5468 can be left for an alternative SQL dialect implementation in Spark that aims for completeness and interoperability rather than backwards compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6741][SQL] Add support for SELECT ALL s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5469#issuecomment-91933405
[Test build #30089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30089/consoleFull) for PR 5469 at commit [`3cdee0c`](https://github.com/apache/spark/commit/3cdee0cf6d8dec2a0e646f60758ccd097f30a92d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6741][SQL] Add support for SELECT ALL s...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5469#issuecomment-94539387
@smola, that sounds like a great idea to me! I would really like to have better SQL92 support, but the parser combinators are pretty brittle and we have gotten a lot of complaints in the past when we have added keywords the broke existing queries.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6741][SQL] Add support for SELECT ALL s...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5469#issuecomment-91933117
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6741][SQL] Add support for SELECT ALL s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5469#issuecomment-91946406
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30089/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6741][SQL] Add support for SELECT ALL s...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5469#issuecomment-94952519
Given the plan to do this as a plugable parser could you close this issue for now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6741][SQL] Add support for SELECT ALL s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6741][SQL] Add support for SELECT ALL s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5469#issuecomment-91827352
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6741][SQL] Add support for SELECT ALL s...
Posted by smola <gi...@git.apache.org>.
Github user smola commented on the pull request:
https://github.com/apache/spark/pull/5469#issuecomment-92106383
@marmbrus My goal is to have a parser as compatible as possible with standard SQL. *SELECT [ALL | DISTINCT]* is the standard syntax since SQL'92 and it's implemented this way in every major SQL implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org