You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2023/12/21 04:23:04 UTC

Re: [PR] [SPARK-43049][SQL] Use CLOB instead of VARCHAR(255) for StringType for Oracle JDBC [spark]

cloud-fan commented on PR #40683:
URL: https://github.com/apache/spark/pull/40683#issuecomment-1865456175

   How about we revert it first? This brings perf issues for all use cases but only benefits corner cases where the string value is larger than 255.
   
   We can have a config to control the varchar length for oracle dialect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org